From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60083: 29.0.60; eshell-elecslash when in the root directory of a remote host Date: Sun, 18 Dec 2022 22:15:24 +0200 Message-ID: <83359cfoyr.fsf@gnu.org> References: <3f509b4aaaa957d43a429b2ee843c88312486e86.camel@laposte.net> <83o7s1f1at.fsf@gnu.org> <5cddf6c8-ac52-0bd7-c523-82ce1e75c99f@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6133"; mail-complaints-to="usenet@ciao.gmane.io" Cc: montag451@laposte.net, 60083@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 21:16:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7054-0001Qo-BI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 21:16:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p704p-0005zy-RJ; Sun, 18 Dec 2022 15:16:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p704o-0005zk-OF for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 15:16:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p704o-0000Mq-GL for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 15:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p704o-0004MZ-Cr for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 15:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60083 X-GNU-PR-Package: emacs Original-Received: via spool by 60083-submit@debbugs.gnu.org id=B60083.167139452316744 (code B ref 60083); Sun, 18 Dec 2022 20:16:02 +0000 Original-Received: (at 60083) by debbugs.gnu.org; 18 Dec 2022 20:15:23 +0000 Original-Received: from localhost ([127.0.0.1]:35708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p704B-0004M0-6x for submit@debbugs.gnu.org; Sun, 18 Dec 2022 15:15:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p704A-0004Lq-7O for 60083@debbugs.gnu.org; Sun, 18 Dec 2022 15:15:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7044-0000H2-9r; Sun, 18 Dec 2022 15:15:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lbMD6GbFm+fYHW+CKL+P/dafcungIScM/P9Sk/D9UCw=; b=b2TQuCPzCs+W MLy75J9AHpc0ayxPvG/mz1EA2IjitIS83DoIaYOFvlovSUQDhAbzaFxpGqw3aSNLlGD2nGCfAY9MI 9I+J71qi+8BKKxF8Ev8EaMAU9MtZ8ndXFVT3AVGP7HOraknuiTaN+pwgYC196KP9Ydu4xLafsdbXc adXKyZoeixrT+/GyXtmNipjp1WGcZ7IcCYqKYVq4g2boHzSXggrjPXnFfs8QB/fiUJLaM0P/P/exa Fk60ckoTgzJ71gge+Dc4RlGMAECDA/n0bEHPcrnl0J3nnAsY2zOD5HMjWi5UrDTMW5U/wGkXg+qEx mrkIha+UXAgfKBK9WMFLvw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7043-0004L1-Ql; Sun, 18 Dec 2022 15:15:16 -0500 In-Reply-To: <5cddf6c8-ac52-0bd7-c523-82ce1e75c99f@gmail.com> (message from Jim Porter on Sun, 18 Dec 2022 12:04:47 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251377 Archived-At: > Date: Sun, 18 Dec 2022 12:04:47 -0800 > Cc: 60083@debbugs.gnu.org > From: Jim Porter > > On 12/18/2022 2:34 AM, Eli Zaretskii wrote: > >> Date: Thu, 15 Dec 2022 00:46:50 +0100 > >> From: montag451 via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> While testing the new eshell module 'eshell-elecslash' I found a bug > >> when the default-directory is the root of a remote host. To reproduce > >> the problem type the following in a eshell buffer (replacing "method" > >> and "host" by appropriate values): > >> > >> $ cd /method:host:/ > >> $ cd / <--- here the "/" should be replaced by "/method:host:/" but > >> instead nothing happen > >> > >> I've attached a patch to this email which fixes this issue. > > > > Jim, are you looking into this issue? > > Thanks. I missed the original message. The patch looks good to me, > although it compiles with the following warning: > > In eshell-electric-forward-slash: > ../../lisp/eshell/em-elecslash.el:98:18: Warning: Unused lexical > variable `localname' > > Looking through the code, I think we can just remove that variable. > > Since this is a small change, and fixes a corner case in a new feature, > I think it would make sense to go on the release branch, though I'll > defer to you on this, Eli. The fact that the new code (with the removal > of 'localname') is a bit simpler helps too. Yes, the release branch is fine for this. Especially since this module is AFAIU new in Emacs 29. Thanks.