From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning Date: Wed, 14 Oct 2015 20:42:25 +0300 Message-ID: <831tcxxs72.fsf@gnu.org> References: <83fv1dxvmq.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1444844674 20933 80.91.229.3 (14 Oct 2015 17:44:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Oct 2015 17:44:34 +0000 (UTC) Cc: 21681@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 14 19:44:21 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZmQ67-0003Yk-IG for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Oct 2015 19:44:19 +0200 Original-Received: from localhost ([::1]:43752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmQ66-0005Xp-Mu for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Oct 2015 13:44:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmQ4v-0004EO-Kc for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2015 13:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmQ4s-0000Ae-Ds for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2015 13:43:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60384) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmQ4s-0000Aa-AN for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2015 13:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZmQ4s-0001iP-2F for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2015 13:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2015 17:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21681 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21681-submit@debbugs.gnu.org id=B21681.14448445516556 (code B ref 21681); Wed, 14 Oct 2015 17:43:01 +0000 Original-Received: (at 21681) by debbugs.gnu.org; 14 Oct 2015 17:42:31 +0000 Original-Received: from localhost ([127.0.0.1]:51092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmQ4N-0001hg-0J for submit@debbugs.gnu.org; Wed, 14 Oct 2015 13:42:31 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:41343) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmQ4J-0001hU-SR for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 13:42:28 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NW8000000QZGK00@a-mtaout23.012.net.il> for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 20:42:26 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NW8000SL16PEC40@a-mtaout23.012.net.il>; Wed, 14 Oct 2015 20:42:26 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107615 Archived-At: > Date: Wed, 14 Oct 2015 12:56:28 -0400 > From: Noam Postavsky > Cc: 21681@debbugs.gnu.org > > On Wed, Oct 14, 2015 at 12:28 PM, Eli Zaretskii wrote: > > Why 'files', and not something more concrete, like > > 'file-local-variables'? > > The docstring for display-warning says the TYPE arg should be a custom group. > > display-warning doesn't actually enforce this, and it looks like the > choice of symbol(s) is only relevant to warning-suppress-log-types. > Perhaps the TYPE should be '(files local-variables) so the user can > suppress it along with all files warnings or just suppress it on it's > own, but display-warning only prints the 1st symbol of the list so the > warning text itself wouldn't change. I find "files" no more explanatory that "warning". If we lack infrastructure to display meaningful messages that unequivocally point to the nature of the problem, let's add the missing infrastructure. Thanks.