From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47437: 28.0.50; pulse-momentary-highlight-overlay breaks if background color is inherited Date: Sun, 28 Mar 2021 16:26:08 +0300 Message-ID: <831rbzo1e7.fsf@gnu.org> References: <87czvks2kp.fsf@kenko.localhost.com> <835z1bo3x8.fsf@gnu.org> <87a6qnsae0.fsf@kenko.localhost.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13591"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47437@debbugs.gnu.org To: Ingo Lohmar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 28 15:27:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQVS0-0003Qv-79 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 15:27:32 +0200 Original-Received: from localhost ([::1]:42888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQVRz-0005BR-8m for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Mar 2021 09:27:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQVRW-00059n-5F for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 09:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQVRV-0002yb-Su for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 09:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQVRV-0004Zq-O8 for bug-gnu-emacs@gnu.org; Sun, 28 Mar 2021 09:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Mar 2021 13:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47437 X-GNU-PR-Package: emacs Original-Received: via spool by 47437-submit@debbugs.gnu.org id=B47437.161693797717537 (code B ref 47437); Sun, 28 Mar 2021 13:27:01 +0000 Original-Received: (at 47437) by debbugs.gnu.org; 28 Mar 2021 13:26:17 +0000 Original-Received: from localhost ([127.0.0.1]:45571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQVQm-0004Ym-EF for submit@debbugs.gnu.org; Sun, 28 Mar 2021 09:26:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQVQk-0004Ya-Pl for 47437@debbugs.gnu.org; Sun, 28 Mar 2021 09:26:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52377) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQVQd-0002bw-8r; Sun, 28 Mar 2021 09:26:08 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1052 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lQVQW-0000ls-5o; Sun, 28 Mar 2021 09:26:05 -0400 In-Reply-To: <87a6qnsae0.fsf@kenko.localhost.com> (message from Ingo Lohmar on Sun, 28 Mar 2021 14:58:15 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203162 Archived-At: > From: Ingo Lohmar > Date: Sun, 28 Mar 2021 14:58:15 +0200 > > 1) I would have suggested to use 'default' myself, if the docstring of > `face-background' were not (IMHO) misleading: The paragraph describing > INHERIT (wrongly) suggested to me that giving a face would also > disregard the :inherit attribute. > > The same applies to the other helper functions (`face-foreground' etc). > The docstring of `face-attribute' is clearer ("further merged") about > the fact that inherit is still followed in the non-t case. > > I suggest to amend the last sentence in the inherit paragraph of all > these docstrings, from > > "If INHERIT is a face or a list of faces, then it is used to try to > resolve an unspecified ..." > > to > > "If INHERIT is a face or a list of faces, then it is used to try to > resolve a value that is still unspecified after considering the > `:inherit' attribute." I made a slightly different change (on the release branch), thanks. > 2) There are two more instances of `face-background' in > `pulse-reset-face' in the same file, one with a 't' INHERIT argument. I > haven't tried to understand the details, but I strongly suspect they > should get the 'default' argument as well. I didn't see any places where a nil value could make a problem, so I didn't change anything here. If you see any problems, please report them.