unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org
Subject: bug#46055: [PATCH] Add rust lang to etags
Date: Mon, 17 May 2021 19:14:34 +0300	[thread overview]
Message-ID: <831ra5tk0l.fsf@gnu.org> (raw)
In-Reply-To: <87y2cdgx7a.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon,  17 May 2021 18:08:09 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: pot@gnu.org,  stefan@marxist.se,  contact@parouby.fr,
>   46055@debbugs.gnu.org
> Date: Mon, 17 May 2021 18:08:09 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Just say "make" in that directory, it should finish with no errors.
> 
> If I do that, I get an enormous diff in the terminal, and it then
> finishes with:
> 
>  y-src/parse.c,520
>  #define YYBISON 4,64
> make[1]: *** [Makefile:63: ediff_1] Error 1
> make[1]: Leaving directory '/home/larsi/src/emacs/trunk/test/manual/etags'
> make: *** [Makefile:54: check] Error 2

Try again, I just fixed this.

The problem is that people make mechanic changes to all our sources,
and forget that files in this particular directory shall NOT be
changed, or else if they are, the '*good*' files with expected results
should be updated at that very moment.  Examples of such changes
include: yearly update of copyright years, removal of obsolete
variables across the board, spelling fixes, etc.  Just do

  git log test/manual/etags/c-src/abbrev.c

and you will see what I mean.  Each such change breaks this test
suite, and requires manual inspection of the diffs to convince
ourselves that the new results are correct and not bugs.





  reply	other threads:[~2021-05-17 16:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 19:01 bug#46055: [PATCH] Add rust lang to etags Pierre-Antoine Rouby
2021-01-23 19:59 ` Lars Ingebrigtsen
2021-01-23 20:23   ` Eli Zaretskii
2021-01-25 10:08     ` parouby
2021-01-25 10:09       ` Lars Ingebrigtsen
2021-04-21  3:19         ` Stefan Kangas
2021-04-21  8:54           ` Eli Zaretskii
2021-01-25 10:15       ` Pierre-Antoine Rouby
2021-01-25 14:33       ` Pierre-Antoine Rouby
2021-04-21 12:39         ` Stefan Kangas
2021-04-21 15:02           ` Francesco Potortì
2021-05-17 15:23             ` Lars Ingebrigtsen
2021-05-17 15:51               ` Eli Zaretskii
2021-05-17 16:08                 ` Lars Ingebrigtsen
2021-05-17 16:14                   ` Eli Zaretskii [this message]
2021-05-17 16:27                     ` Lars Ingebrigtsen
2021-05-17 16:31                       ` Lars Ingebrigtsen
2021-05-17 16:40                         ` Eli Zaretskii
2021-05-18 13:44                           ` Lars Ingebrigtsen
2021-05-20 10:03                             ` Eli Zaretskii
2021-05-17 15:21         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831ra5tk0l.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=46055@debbugs.gnu.org \
    --cc=contact@parouby.fr \
    --cc=larsi@gnus.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).