From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46055: [PATCH] Add rust lang to etags Date: Mon, 17 May 2021 19:14:34 +0300 Message-ID: <831ra5tk0l.fsf@gnu.org> References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> <834kf1tl2c.fsf@gnu.org> <87y2cdgx7a.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18917"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 17 18:48:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ligQI-0004gO-AN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 18:48:54 +0200 Original-Received: from localhost ([::1]:38632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ligQH-0004ZM-9T for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 12:48:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liftW-000135-E1 for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 12:15:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42123) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1liftW-0000Hn-62 for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 12:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1liftW-00008m-1Y for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 12:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 May 2021 16:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46055 X-GNU-PR-Package: emacs Original-Received: via spool by 46055-submit@debbugs.gnu.org id=B46055.1621268081499 (code B ref 46055); Mon, 17 May 2021 16:15:01 +0000 Original-Received: (at 46055) by debbugs.gnu.org; 17 May 2021 16:14:41 +0000 Original-Received: from localhost ([127.0.0.1]:53669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1liftB-00007y-2y for submit@debbugs.gnu.org; Mon, 17 May 2021 12:14:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lift9-00007j-6h for 46055@debbugs.gnu.org; Mon, 17 May 2021 12:14:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50068) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lift3-00007a-4L; Mon, 17 May 2021 12:14:33 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3288 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lift2-00065m-Ek; Mon, 17 May 2021 12:14:32 -0400 In-Reply-To: <87y2cdgx7a.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 17 May 2021 18:08:09 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206737 Archived-At: > From: Lars Ingebrigtsen > Cc: pot@gnu.org, stefan@marxist.se, contact@parouby.fr, > 46055@debbugs.gnu.org > Date: Mon, 17 May 2021 18:08:09 +0200 > > Eli Zaretskii writes: > > > Just say "make" in that directory, it should finish with no errors. > > If I do that, I get an enormous diff in the terminal, and it then > finishes with: > > y-src/parse.c,520 > #define YYBISON 4,64 > make[1]: *** [Makefile:63: ediff_1] Error 1 > make[1]: Leaving directory '/home/larsi/src/emacs/trunk/test/manual/etags' > make: *** [Makefile:54: check] Error 2 Try again, I just fixed this. The problem is that people make mechanic changes to all our sources, and forget that files in this particular directory shall NOT be changed, or else if they are, the '*good*' files with expected results should be updated at that very moment. Examples of such changes include: yearly update of copyright years, removal of obsolete variables across the board, spelling fixes, etc. Just do git log test/manual/etags/c-src/abbrev.c and you will see what I mean. Each such change breaks this test suite, and requires manual inspection of the diffs to convince ourselves that the new results are correct and not bugs.