unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org
Subject: bug#46055: [PATCH] Add rust lang to etags
Date: Mon, 17 May 2021 18:27:39 +0200	[thread overview]
Message-ID: <87tun1gwas.fsf@gnus.org> (raw)
In-Reply-To: <831ra5tk0l.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 17 May 2021 19:14:34 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> The problem is that people make mechanic changes to all our sources,
> and forget that files in this particular directory shall NOT be
> changed, or else if they are, the '*good*' files with expected results
> should be updated at that very moment.  Examples of such changes
> include: yearly update of copyright years, removal of obsolete
> variables across the board, spelling fixes, etc.  Just do
>
>   git log test/manual/etags/c-src/abbrev.c
>
> and you will see what I mean.

Yes, I was most puzzled when trying to find out just what was going on
in that directory.  I wondered whether the test cases were somehow...
copying files from the main Emacs source directories (since many of them
have the same names and are updated in this way).

> Each such change breaks this test suite, and requires manual
> inspection of the diffs to convince ourselves that the new results are
> correct and not bugs.

Yup.  So I think a README to explain what's going on in that directory
would be helpful.  :-)

I've now added a test case for Rust.  (Note: I don't know Rust at all.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-05-17 16:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 19:01 bug#46055: [PATCH] Add rust lang to etags Pierre-Antoine Rouby
2021-01-23 19:59 ` Lars Ingebrigtsen
2021-01-23 20:23   ` Eli Zaretskii
2021-01-25 10:08     ` parouby
2021-01-25 10:09       ` Lars Ingebrigtsen
2021-04-21  3:19         ` Stefan Kangas
2021-04-21  8:54           ` Eli Zaretskii
2021-01-25 10:15       ` Pierre-Antoine Rouby
2021-01-25 14:33       ` Pierre-Antoine Rouby
2021-04-21 12:39         ` Stefan Kangas
2021-04-21 15:02           ` Francesco Potortì
2021-05-17 15:23             ` Lars Ingebrigtsen
2021-05-17 15:51               ` Eli Zaretskii
2021-05-17 16:08                 ` Lars Ingebrigtsen
2021-05-17 16:14                   ` Eli Zaretskii
2021-05-17 16:27                     ` Lars Ingebrigtsen [this message]
2021-05-17 16:31                       ` Lars Ingebrigtsen
2021-05-17 16:40                         ` Eli Zaretskii
2021-05-18 13:44                           ` Lars Ingebrigtsen
2021-05-20 10:03                             ` Eli Zaretskii
2021-05-17 15:21         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tun1gwas.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=46055@debbugs.gnu.org \
    --cc=contact@parouby.fr \
    --cc=eliz@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).