From: Platon Pronko <platon7pronko@gmail.com>
To: Alan Mackenzie <acm@muc.de>
Cc: 45792@debbugs.gnu.org
Subject: bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file
Date: Sun, 31 Jan 2021 15:11:11 +0300 [thread overview]
Message-ID: <81a72c8d-b92c-2eea-5ef3-ec4988634095@gmail.com> (raw)
In-Reply-To: <YBaZoZS1+1p3fYOG@ACM>
Hi!
Tested the commit, the issue is gone - both with and without (not (minibufferp)).
However I noticed that (minibufferp) can return nil when it is called on *Minibuf-1* (I noticed this when suddenly dvorak was enabled in minibuffer even though (not (minibufferp)) guard was still in the code).
Here's some debug code I used to check minibufferp return:
(define-minor-mode dvorak-minor-mode "Use english-dvorak input method." :lighter nil
(message (format "%s %s" (buffer-name (current-buffer)) (minibufferp)))
(if (and dvorak-minor-mode (not (minibufferp)))
(activate-input-method "english-dvorak")))
(define-global-minor-mode global-dvorak-mode dvorak-minor-mode dvorak-minor-mode)
(global-dvorak-mode t)
And here's sample output in the *Message* buffer:
For information about GNU Emacs and the GNU system, type C-h C-a.
*scratch* nil
Loading quail/latin-post...done
*Minibuf-0* t
*Messages* nil
*Echo Area 0* nil
*Echo Area 1* nil
*load* nil
*Minibuf-1* nil <<-- here it thinks that Minibuf-1 is not a minibuffer
*Minibuf-0* t
Is this supposed to happen?
Best regards,
Platon Pronko
next prev parent reply other threads:[~2021-01-31 12:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 16:09 bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file Platon Pronko
2021-01-12 9:06 ` martin rudalics
2021-01-12 10:29 ` Platon Pronko
2021-01-12 19:00 ` Alan Mackenzie
2021-01-16 16:36 ` Alan Mackenzie
2021-01-17 7:50 ` Platon Pronko
2021-01-30 18:35 ` Alan Mackenzie
2021-01-31 8:54 ` Platon Pronko
2021-01-31 11:50 ` Alan Mackenzie
2021-01-31 12:11 ` Platon Pronko [this message]
2021-01-31 17:01 ` Alan Mackenzie
2021-01-31 19:37 ` Platon Pronko
2021-01-31 20:06 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81a72c8d-b92c-2eea-5ef3-ec4988634095@gmail.com \
--to=platon7pronko@gmail.com \
--cc=45792@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).