unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Platon Pronko <platon7pronko@gmail.com>
To: martin rudalics <rudalics@gmx.at>, 45792@debbugs.gnu.org
Cc: Alan Mackenzie <acm@muc.de>
Subject: bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file
Date: Tue, 12 Jan 2021 13:29:23 +0300	[thread overview]
Message-ID: <c7c26a0e-f608-f322-3d06-90be431b91c1@gmail.com> (raw)
In-Reply-To: <0f37c263-a361-7360-666a-4c7054ecf329@gmx.at>

Yes, of course minibufferp is much cleaner - I just wasn't aware of its existence :)

But the problem still persists if I refactor the code to use it. Here's the code I used:

(define-minor-mode dvorak-minor-mode "Use english-dvorak input method." :lighter nil
   (if (and dvorak-minor-mode (not (minibufferp)))
     (activate-input-method "english-dvorak")))
(define-global-minor-mode global-dvorak-mode dvorak-minor-mode dvorak-minor-mode)
(global-dvorak-mode t)

Actually even removing (not (minibufferp)) altogether has no effect on the issue.

Best regards,
Platon Pronko





  reply	other threads:[~2021-01-12 10:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 16:09 bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file Platon Pronko
2021-01-12  9:06 ` martin rudalics
2021-01-12 10:29   ` Platon Pronko [this message]
2021-01-12 19:00 ` Alan Mackenzie
2021-01-16 16:36 ` Alan Mackenzie
2021-01-17  7:50   ` Platon Pronko
2021-01-30 18:35     ` Alan Mackenzie
2021-01-31  8:54       ` Platon Pronko
2021-01-31 11:50         ` Alan Mackenzie
2021-01-31 12:11           ` Platon Pronko
2021-01-31 17:01             ` Alan Mackenzie
2021-01-31 19:37               ` Platon Pronko
2021-01-31 20:06                 ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7c26a0e-f608-f322-3d06-90be431b91c1@gmail.com \
    --to=platon7pronko@gmail.com \
    --cc=45792@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).