From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Platon Pronko Newsgroups: gmane.emacs.bugs Subject: bug#45792: 28.0.50; regression in commit c7c154bb, minibuffer is not closed after opening a file Date: Sun, 31 Jan 2021 15:11:11 +0300 Message-ID: <81a72c8d-b92c-2eea-5ef3-ec4988634095@gmail.com> References: <75aca8c3-6c8f-2a66-399e-7116d99c91d3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28187"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 Cc: 45792@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 31 13:12:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6BaQ-0007Ds-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Jan 2021 13:12:14 +0100 Original-Received: from localhost ([::1]:38694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6BaP-0001v6-Gi for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Jan 2021 07:12:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6BaE-0001tt-EA for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2021 07:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44972) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6BaE-0005a7-6W for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2021 07:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l6BaE-0005ga-1j for bug-gnu-emacs@gnu.org; Sun, 31 Jan 2021 07:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Platon Pronko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Jan 2021 12:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45792 X-GNU-PR-Package: emacs Original-Received: via spool by 45792-submit@debbugs.gnu.org id=B45792.161209508021807 (code B ref 45792); Sun, 31 Jan 2021 12:12:02 +0000 Original-Received: (at 45792) by debbugs.gnu.org; 31 Jan 2021 12:11:20 +0000 Original-Received: from localhost ([127.0.0.1]:56518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6BZY-0005ff-Em for submit@debbugs.gnu.org; Sun, 31 Jan 2021 07:11:20 -0500 Original-Received: from mail-lj1-f175.google.com ([209.85.208.175]:36217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6BZW-0005fR-Qo for 45792@debbugs.gnu.org; Sun, 31 Jan 2021 07:11:20 -0500 Original-Received: by mail-lj1-f175.google.com with SMTP id l12so16017589ljc.3 for <45792@debbugs.gnu.org>; Sun, 31 Jan 2021 04:11:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=L/PcU67KY1TNEGVXYruEnHG5CBk1P/TtsBKyycJ7Yto=; b=bUbzTRAUpTCrjnba0D8WuWMN6aWrBH+fcsQqtFGxudMkRF4DK2Xi2CJGCtqEGv954G VgmszXTyR15tU/HqsOzRaTwIiDFuP9576QuIJlzYJvNJkjnbdvdI+Aox0PI/tOSMG/6T XctkfVY9Zzp2uIl4s4eVRMprHtIUbFa3DMYmgBPMaXRu3ycYbSZuWRC0frxMgQLnfsfK kkoHQK9gsm+aWRHHpUhzRP443oFiGzn4mV1qjRXVcK5ACjJveBEjMvC9SGfKEp0TOuWQ VzaEDRiyD8qSG0JFqj5BIxTMHgre70uz6J0IIdNhfC4wlXFG2F0o/y6Lin4VVdeBGwLI boIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L/PcU67KY1TNEGVXYruEnHG5CBk1P/TtsBKyycJ7Yto=; b=r1oNf76crUMnRSCltTKqqBXeF42wXE5Wn93WKb5Sc6IC7K+x+ML9FdOuQCT6QRP9HL wbEYZsZ2k5HDiGKUhOTw5CdhTRXfqAcrdKl9msDtcEwkPPIWOjY39c3nf/wBTj0GLk00 helI2CxyIpJ6Ujc0TCP2hEIgbskyd6wDxZvkoxFf2eT3gLk8RMpcisEs8FxDb0UgyFTU hQKqj1Q8v4Y3H0B9zbUJsra2oUWUT8v9sNUufn53hcBWKBheYrtias0YiRknWyWhne8N 4ONdStiutXmJg1qd/DMP+dJU23boXxl96fPV86BD0Y1BnpwNB3apWpXP2IM08H8orXo3 zflQ== X-Gm-Message-State: AOAM533CU1K/CtV/zhZ0HZ8iH8dNjkJCFhVDeb42YtErrDR6nu8HVCfC 2dU/gcfoCVJtUHDBJyuo5Zo= X-Google-Smtp-Source: ABdhPJxF9koZ9qEkOhaxPRWyAPuGk0UlEu0walV5dP1KV1eE5l8fXYPbA84keFFKU2TyjgRvf9Kzgw== X-Received: by 2002:a2e:854d:: with SMTP id u13mr7043205ljj.439.1612095072871; Sun, 31 Jan 2021 04:11:12 -0800 (PST) Original-Received: from [192.168.1.70] (109-252-80-249.nat.spd-mgts.ru. [109.252.80.249]) by smtp.gmail.com with ESMTPSA id d23sm3374826ljo.17.2021.01.31.04.11.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Jan 2021 04:11:12 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199002 Archived-At: Hi! Tested the commit, the issue is gone - both with and without (not (minibufferp)). However I noticed that (minibufferp) can return nil when it is called on *Minibuf-1* (I noticed this when suddenly dvorak was enabled in minibuffer even though (not (minibufferp)) guard was still in the code). Here's some debug code I used to check minibufferp return: (define-minor-mode dvorak-minor-mode "Use english-dvorak input method." :lighter nil (message (format "%s %s" (buffer-name (current-buffer)) (minibufferp))) (if (and dvorak-minor-mode (not (minibufferp))) (activate-input-method "english-dvorak"))) (define-global-minor-mode global-dvorak-mode dvorak-minor-mode dvorak-minor-mode) (global-dvorak-mode t) And here's sample output in the *Message* buffer: For information about GNU Emacs and the GNU system, type C-h C-a. *scratch* nil Loading quail/latin-post...done *Minibuf-0* t *Messages* nil *Echo Area 0* nil *Echo Area 1* nil *load* nil *Minibuf-1* nil <<-- here it thinks that Minibuf-1 is not a minibuffer *Minibuf-0* t Is this supposed to happen? Best regards, Platon Pronko