bug#1612: Org-menu "Set Items" not bound

bug#1612: Org-menu "Set Items" not bound

[David Reitter]

As below - this seems to occur with Emacs 23 as well.

In org-mode, over a header line, e.g.

* Hello World

using the Tags/Set Tags command in the Org menu isn't bound to a  
useful command.
C-c C-c works fine, and I think it's supposed to the the right thing.

Apologies if this doesn't make sense - I don't know org-mode, and I've  
just learned enough to verify the complaint coming in from the user  
below.


Begin forwarded message:

> From: Robert Goldman <rpgoldman@sift.info>
> Date: 17 December 2008 11:03:28 EST
> To: Development of Aquamacs Emacs <aquamacs-devel@aquamacs.org>
> Subject: [Aquamacs-devel] Menu items not working for me
> Reply-To: Development of Aquamacs Emacs <aquamacs-devel@aquamacs.org>
>
> At least some of the time the menu bar items aren't working for me.   
> For
> example, when I select the "Set tags" command in the Org mode menu,
> nothing happens.  When I use C-h c to find out what this menu  
> command is
> bound to, I find that it's bound to menu-function-16.  However, by
> contrast, the menu item Window -> Show buffer in new frame is bound to
> make-frame-command, and works just fine.
>
> Have I somehow (once again) gonked my configuration?  Or is this a  
> real
> problem?
>
> Aquamacs-version 1.6CVS, MacOSX 10.5.5

bug#1632: Org-menu "Set Items" not bound

[Robert Goldman]

[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]

Backgrond:  I have been finding that the Set Tags menu command didn't
work for me (on aquamacs).  I reported that to aquamacs-bugs, but David
Reitter there found that it was an org-mode bug.  I don't believe he
reported it to orgmode list --- went to emacs-pretest-bug instead.
Here's the analysis and a proposed patch.

I just looked at the output of help-variable on org-org-menu
and I see:

	(TAGS\ and\ Properties menu-item "TAGS and Properties"
			       (keymap "TAGS and Properties"
				       (Set\ Tags menu-item "Set Tags" menu-function-16
:key-sequence nil)
				       (Change\ tag\ in\ region menu-item "Change tag in region"
menu-function-17 :key-sequence nil :enable
								(org-region-active-p))
				       (nil menu-item "--")
				       (Set\ property menu-item "Set property" menu-function-18
:key-sequence nil)
				       (Column\ view\ of\ properties menu-item "Column view of
properties" org-columns)
				       (Insert\ Column\ View\ DBlock menu-item "Insert Column View
DBlock" org-insert-columns-dblock)))

So I confirm what David reports, if you look about you'll see that the
keymap entries for "Set Tags" and "Set Property" aren't properly
initialized.

I find that the following are also not initialized:

Sparse\ trees\ open\ ARCHIVE\ trees
Cycling\ opens\ ARCHIVE\ trees
Set\ property
Record\ DONE\ time
Edit\ File\ List
Descriptive\ Links
Literal\ Links
Export\ LaTeX\ fragments\ as\ images

and all of the entries for my org agenda files.

Looking at the org.el code, I see that these correspond to entries in
the org-org-mode menu that are quoted.  For example, I see:

["Set Tags" 'org-set-tags-command t]

which doesn't work, but we also see

["Priority Down" org-shiftdown t]

which does work.

When I cut out these quotes, the menu items work for me.  I'm attaching
a patch file.




[-- Attachment #2: menu.patch --]
[-- Type: text/plain, Size: 769 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 3df04e2..2461267 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -13342,10 +13342,10 @@ See the individual commands for more information."
      ["Priority Up" org-shiftup t]
      ["Priority Down" org-shiftdown t])
     ("TAGS and Properties"
-     ["Set Tags" 'org-set-tags-command t]
-     ["Change tag in region" 'org-change-tag-in-region (org-region-active-p)]
+     ["Set Tags" org-set-tags-command t]
+     ["Change tag in region" org-change-tag-in-region (org-region-active-p)]
      "--"
-     ["Set property" 'org-set-property t]
+     ["Set property" org-set-property t]
      ["Column view of properties" org-columns t]
      ["Insert Column View DBlock" org-insert-columns-dblock t])
     ("Dates and Scheduling"