From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Goldman Newsgroups: gmane.emacs.bugs Subject: bug#1632: Org-menu "Set Items" not bound Date: Thu, 18 Dec 2008 12:24:35 -0600 Message-ID: <494A9563.4010103__49845.6880254254$1229637007$gmane$org@sift.info> References: <494922D0.3020807@sift.info> <811717A9-751A-4D17-B1A9-25EB74F606B5@gmail.com> Reply-To: Robert Goldman , 1632@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000505040900020807090007" X-Trace: ger.gmane.org 1229636933 22242 80.91.229.12 (18 Dec 2008 21:48:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Dec 2008 21:48:53 +0000 (UTC) Cc: "aquamacs-bugs@aquamacs.org Bugs" , emacs-pretest-bug@gnu.org To: emacs-orgmode@gnu.org, Carsten Dominik Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 18 22:49:56 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LDQkk-0005K0-0n for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Dec 2008 22:49:54 +0100 Original-Received: from localhost ([127.0.0.1]:53871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDQjX-0006iX-GL for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Dec 2008 16:48:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LDNrG-0007bp-5X for bug-gnu-emacs@gnu.org; Thu, 18 Dec 2008 13:44:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LDNrE-0007aQ-QF for bug-gnu-emacs@gnu.org; Thu, 18 Dec 2008 13:44:25 -0500 Original-Received: from [199.232.76.173] (port=39517 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDNrE-0007aA-KG for bug-gnu-emacs@gnu.org; Thu, 18 Dec 2008 13:44:24 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60338) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LDNrD-0008Tg-IG for bug-gnu-emacs@gnu.org; Thu, 18 Dec 2008 13:44:24 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBIIiKCV029322; Thu, 18 Dec 2008 10:44:20 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mBIIU5GJ024354; Thu, 18 Dec 2008 10:30:05 -0800 X-Loop: don@donarmstrong.com Resent-From: Robert Goldman Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 18 Dec 2008 18:30:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1632 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122962490623993 (code B ref -1); Thu, 18 Dec 2008 18:30:05 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 18 Dec 2008 18:28:26 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBIISMR0023985 for ; Thu, 18 Dec 2008 10:28:23 -0800 Original-Received: from mx10.gnu.org ([199.232.76.166]:35311) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LDNax-0004w8-70 for emacs-pretest-bug@gnu.org; Thu, 18 Dec 2008 13:27:35 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LDNbg-0005qA-TN for emacs-pretest-bug@gnu.org; Thu, 18 Dec 2008 13:28:21 -0500 Original-Received: from outbound-mail-32.bluehost.com ([69.89.18.152]:42542) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LDNbg-0005pw-G4 for emacs-pretest-bug@gnu.org; Thu, 18 Dec 2008 13:28:20 -0500 Original-Received: (qmail 15974 invoked by uid 0); 18 Dec 2008 18:24:41 -0000 Original-Received: from unknown (HELO box188.bluehost.com) (69.89.25.188) by outboundproxy2.bluehost.com with SMTP; 18 Dec 2008 18:24:41 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=sift.info; h=Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:X-Enigmail-Version:Content-Type:X-Identified-User; b=dx7dKZ8g6hzp2DBbeb9ZdW1p8RmRrljuR30Au0jar/dPpTm76qMY5sV+UXniHHRg9vshFw7d1IxNZmly5eoX5KKPm1jHETO9KRCjTcm+Xt5xG9F44QoKr98Vl1dEV/Xb; Original-Received: from [75.146.46.193] (helo=rpgoldman-2.sift.info) by box188.bluehost.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1LDNY6-00068Q-EB; Thu, 18 Dec 2008 11:24:38 -0700 User-Agent: Thunderbird 2.0.0.18 (Macintosh/20081105) In-Reply-To: <811717A9-751A-4D17-B1A9-25EB74F606B5@gmail.com> X-Enigmail-Version: 0.95.7 X-Identified-User: {2100:box188.bluehost.com:siftinfo:sift.info} {sentby:smtp auth 75.146.46.193 authed with rgoldman+sift.info} X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 18 Dec 2008 13:44:25 -0500 X-Mailman-Approved-At: Thu, 18 Dec 2008 16:48:21 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23365 Archived-At: This is a multi-part message in MIME format. --------------000505040900020807090007 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Backgrond: I have been finding that the Set Tags menu command didn't work for me (on aquamacs). I reported that to aquamacs-bugs, but David Reitter there found that it was an org-mode bug. I don't believe he reported it to orgmode list --- went to emacs-pretest-bug instead. Here's the analysis and a proposed patch. I just looked at the output of help-variable on org-org-menu and I see: (TAGS\ and\ Properties menu-item "TAGS and Properties" (keymap "TAGS and Properties" (Set\ Tags menu-item "Set Tags" menu-function-16 :key-sequence nil) (Change\ tag\ in\ region menu-item "Change tag in region" menu-function-17 :key-sequence nil :enable (org-region-active-p)) (nil menu-item "--") (Set\ property menu-item "Set property" menu-function-18 :key-sequence nil) (Column\ view\ of\ properties menu-item "Column view of properties" org-columns) (Insert\ Column\ View\ DBlock menu-item "Insert Column View DBlock" org-insert-columns-dblock))) So I confirm what David reports, if you look about you'll see that the keymap entries for "Set Tags" and "Set Property" aren't properly initialized. I find that the following are also not initialized: Sparse\ trees\ open\ ARCHIVE\ trees Cycling\ opens\ ARCHIVE\ trees Set\ property Record\ DONE\ time Edit\ File\ List Descriptive\ Links Literal\ Links Export\ LaTeX\ fragments\ as\ images and all of the entries for my org agenda files. Looking at the org.el code, I see that these correspond to entries in the org-org-mode menu that are quoted. For example, I see: ["Set Tags" 'org-set-tags-command t] which doesn't work, but we also see ["Priority Down" org-shiftdown t] which does work. When I cut out these quotes, the menu items work for me. I'm attaching a patch file. --------------000505040900020807090007 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="menu.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="menu.patch" diff --git a/lisp/org.el b/lisp/org.el index 3df04e2..2461267 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -13342,10 +13342,10 @@ See the individual commands for more information." ["Priority Up" org-shiftup t] ["Priority Down" org-shiftdown t]) ("TAGS and Properties" - ["Set Tags" 'org-set-tags-command t] - ["Change tag in region" 'org-change-tag-in-region (org-region-active-p)] + ["Set Tags" org-set-tags-command t] + ["Change tag in region" org-change-tag-in-region (org-region-active-p)] "--" - ["Set property" 'org-set-property t] + ["Set property" org-set-property t] ["Column view of properties" org-columns t] ["Insert Column View DBlock" org-insert-columns-dblock t]) ("Dates and Scheduling" --------------000505040900020807090007--