From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#9622: [PATCH] Re: bug#9622: 23.3; flet indentation Date: Thu, 30 Sep 2021 10:05:33 +0200 Message-ID: <7A41EEAF-B19C-48A2-9033-275B7E001884@acm.org> References: <504153FB-8633-4755-A91A-DF5DD64E6FAA@acm.org> <87lf3fntdx.fsf@gmail.com> <87tui26027.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17040"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 9622@debbugs.gnu.org, akater To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 30 10:06:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVr5H-0004AE-I1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 10:06:27 +0200 Original-Received: from localhost ([::1]:58198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVr5G-0007f6-ER for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Sep 2021 04:06:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVr4s-0007co-Is for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 04:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVr4s-0003x6-Ar for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 04:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVr4s-0005io-2s for bug-gnu-emacs@gnu.org; Thu, 30 Sep 2021 04:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Sep 2021 08:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9622 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 9622-submit@debbugs.gnu.org id=B9622.163298914621972 (code B ref 9622); Thu, 30 Sep 2021 08:06:02 +0000 Original-Received: (at 9622) by debbugs.gnu.org; 30 Sep 2021 08:05:46 +0000 Original-Received: from localhost ([127.0.0.1]:51382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVr4c-0005iK-Kk for submit@debbugs.gnu.org; Thu, 30 Sep 2021 04:05:46 -0400 Original-Received: from mail1468c50.megamailservers.eu ([91.136.14.68]:52228 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVr4Z-0005i3-97 for 9622@debbugs.gnu.org; Thu, 30 Sep 2021 04:05:44 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1632989136; bh=PG8eUYojJxUU+BLvT6ASegklFEdDn0+66TIFK1b6+yc=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=fPki8IFgFiL5WDEiIp1/SGkWnQi+lwkY2SSYWVm5ufi9YX8Rgmh6CTB63AUCxeYTo 3HK5eiLU3zG7il4M02rHiDKb2CT4ChnyvZlXaUouMoPq4s0zima/bUaSb0dTQbNt++ Fqu0YU/GzZx6tAdGoQLeqMrq9oy/wFZ8uuVFivDg= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18U85XWR019942; Thu, 30 Sep 2021 08:05:35 +0000 In-Reply-To: <87tui26027.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1C.61556FCF.0061, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=QcUFAuXv c=1 sm=1 tr=0 ts=61556fd0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=0pbIO5yG-jWZW8EYeOwA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215950 Archived-At: 30 sep. 2021 kl. 08.37 skrev Lars Ingebrigtsen : >> - I attached flet-tests.sexp which only contains cl-flet forms = written >> the way they are meant to be indented. I think writing them in >> strings in deftest forms would be quite ugly and unreliable. What would be unreliable? > Indeed. I have a new machinery for doing tests like this waiting for > Emacs 29 development to commence to fix this awkwardness. We should insist on tests accompanying any bug fix from the start. = Awkward is better than nothing. If the author finds it too difficult to = write the test then we should help. Akater, we have plenty of indentation tests for other programming modes = already and they employ a variety of methods; there are many examples to = look at. For instance, look at ruby-mode-tests.el; it contains a = converted legacy test (ruby--indent/converted-from-manual-test) that = reindents a separate source file, much like your example. If you need further directions, we will assist.