From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
"Philip Kaludercic" <philipk@posteo.net>,
58950@debbugs.gnu.org
Subject: bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance
Date: Thu, 5 Jan 2023 15:01:17 +0200 [thread overview]
Message-ID: <77d1e30d-a4a8-76fc-925d-9caad2906002@yandex.ru> (raw)
In-Reply-To: <jwvsfgpd35e.fsf-monnier+emacs@gnu.org>
On 05/01/2023 06:31, Stefan Monnier via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
>>>> I'd like to let our language-level specialists to take the deeper look.
> Do we have any reason to believe that the performance of
> `buffer-match-p` is a problem in `display-buffer-alist`?
>
> The benchmark you quote seems to be fairly different from what
> `display-buffer` does. I'm not surprised your optimization improves
> this benchmark, but I'm wondering whether this use-case corresponds to
> a real life situation (and if so which).
I was also wondering that.
>>>> On the last note, I'm curious how many buffers would it take to see a
>>>> 50ms improvement in match-buffers' runtime when using the current
>>>> project-kill-buffer-conditions's value, for example.
> Also, where is `match-buffers` used? I only see it used in
> `lisp/net/rcirc.el` in a way that can trivially be replaced with
> something much more efficient.
I suppose it could replace the use of dolist+project--buffer-check
inside project--buffers-to-kill. But the main target of the patch under
discussion is buffer-match-p, of course.
next prev parent reply other threads:[~2023-01-05 13:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 19:11 bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance Philip Kaludercic
2022-11-04 23:00 ` Philip Kaludercic
2022-11-07 1:04 ` Dmitry Gutov
2022-12-31 13:56 ` Philip Kaludercic
2023-01-05 0:00 ` Dmitry Gutov
2023-01-05 4:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 10:31 ` Mattias Engdegård
2023-01-05 12:55 ` Dmitry Gutov
2023-01-06 11:17 ` Mattias Engdegård
2023-01-06 21:41 ` Dmitry Gutov
2023-01-07 12:57 ` Mattias Engdegård
2023-01-08 21:48 ` Dmitry Gutov
2023-01-09 6:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 13:01 ` Dmitry Gutov [this message]
2023-01-05 0:02 ` Dmitry Gutov
2023-01-05 6:32 ` Eli Zaretskii
2023-01-05 12:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d1e30d-a4a8-76fc-925d-9caad2906002@yandex.ru \
--to=dgutov@yandex.ru \
--cc=58950@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).