From: Dmitry Gutov <dgutov@yandex.ru>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Philip Kaludercic <philipk@posteo.net>,
58950@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance
Date: Sun, 8 Jan 2023 23:48:23 +0200 [thread overview]
Message-ID: <268ed8c9-f56e-dc79-8e57-eeaaab98adc1@yandex.ru> (raw)
In-Reply-To: <34AFCB0F-5F53-4033-BCDF-1B3001285169@acm.org>
On 07/01/2023 14:57, Mattias Engdegård wrote:
> 6 jan. 2023 kl. 22.41 skrev Dmitry Gutov <dgutov@yandex.ru>:
>
>>> (I wish we had (byte-)compiled elisp functions carrying their own source, either as s-exp, string of formatted source text, or source file reference -- that would allow for sensible editing in Customise without performance penalty. But Santa gave me a wool jumper instead, that's nice too.)
>>
>> We kind of have that already, if we just made the type for be 'sexp', or a Lisp form. With all the freedom associated with it, just lower performance compared to a compiled function.
>
> That's short in two respects: performance, and non-retention of formatting and comments. We could store source refs in:
>
> - a hash table weakly keyed on the code object
> - some back corner of byte-code objects
> - OClosures
That's still seems like an overkill for font-lock-global-modes. And it's
hard to draw a line between defcustoms which should have their own
mini-languages, and those that do not.
Or to look at it the other way -- perhaps the line has been drawn now,
since we haven't received any further requests for extending the syntax.
> We have a similar problem with regexps, which are only retained and edited in the traditional syntax.
>
> We are veering off-topic. Sorry about that.
>
>> I'm on the fence regarding changing it, though, for compatibility and ergonomical reasons (it's easier for the user to avoid typing a dot).
>
> Is compatibility a serious concern given that buffer-match-p is new in 29?
This close to a release, it most likely is.
Another compatibility goal (though probably not a hard requirement) is
being able to replace project--buffer-check with the standard code,
while keeping all existing user customizations in
project-kill-buffer-conditions and project-ignore-buffer-conditions.
The alternative would be to have a prolonged migration procedure.
next prev parent reply other threads:[~2023-01-08 21:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 19:11 bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance Philip Kaludercic
2022-11-04 23:00 ` Philip Kaludercic
2022-11-07 1:04 ` Dmitry Gutov
2022-12-31 13:56 ` Philip Kaludercic
2023-01-05 0:00 ` Dmitry Gutov
2023-01-05 4:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 10:31 ` Mattias Engdegård
2023-01-05 12:55 ` Dmitry Gutov
2023-01-06 11:17 ` Mattias Engdegård
2023-01-06 21:41 ` Dmitry Gutov
2023-01-07 12:57 ` Mattias Engdegård
2023-01-08 21:48 ` Dmitry Gutov [this message]
2023-01-09 6:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 13:01 ` Dmitry Gutov
2023-01-05 0:02 ` Dmitry Gutov
2023-01-05 6:32 ` Eli Zaretskii
2023-01-05 12:49 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=268ed8c9-f56e-dc79-8e57-eeaaab98adc1@yandex.ru \
--to=dgutov@yandex.ru \
--cc=58950@debbugs.gnu.org \
--cc=mattiase@acm.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).