From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: philipk@posteo.net, 58950@debbugs.gnu.org
Subject: bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance
Date: Thu, 5 Jan 2023 14:49:17 +0200 [thread overview]
Message-ID: <12687b52-fac4-adf9-a135-e203d1b8eb77@yandex.ru> (raw)
In-Reply-To: <83k021xzio.fsf@gnu.org>
On 05/01/2023 08:32, Eli Zaretskii wrote:
>> Cc:58950@debbugs.gnu.org
>> Date: Thu, 5 Jan 2023 02:02:06 +0200
>> From: Dmitry Gutov<dgutov@yandex.ru>
>>
>> On 31/12/2022 15:56, Philip Kaludercic wrote:
>>> I'd like to backport the
>>> changes from bug#58951 and apply them since they are fixing an actual bug.
>> Speaking of backporting, though, could you address Eli's last message in
>> bug#58951? Also, he seems to have reverted the change in the code, but
>> not in the docstring.
> I hoped the problem would be fixed very soon after the revert. If
> this is not going to happen, please adjust the doc string, or tell me
> how to do that.
Looking more into it, it actually seems like the current code and
doscstring work okay together.
The original description of bug#58951 seems a little confused, given
that show-paren-predicate was already written in the style
(not CONDITION)
and buffer-match-p was apparently working fine with it already. The
revert that you did brought the previous (working) code back. The
dosctring was problematic because it didn't quite match the behavior,
and Philip's change fixed that.
The dosctring can say (as it does now) that
* `not': the cadr is interpreted as a negation of a condition.
or it could more accurately say
* `or': the cdr is a list of recursive conditions, of which at
least one has to be met
as project-kill-buffer-conditions does. These two descriptions are
compatible, however, as long as one only puts 1 item in said list. So we
can sweep the difference under the rug as "implementation details".
And maybe there's nothing more to do in there.
Philip's patch in this bug, however, (the "Optimise performance" one)
changes the semantics of 'not' in a way that would require us to change
show-paren-predicate to '(not . (derived-mode . special-mode)).
I'm not sure if it's intended or not. Let's see what he says on that.
prev parent reply other threads:[~2023-01-05 12:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 19:11 bug#58950: [PATCH] * lisp/subr.el (buffer-match-p): Optimise performance Philip Kaludercic
2022-11-04 23:00 ` Philip Kaludercic
2022-11-07 1:04 ` Dmitry Gutov
2022-12-31 13:56 ` Philip Kaludercic
2023-01-05 0:00 ` Dmitry Gutov
2023-01-05 4:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 10:31 ` Mattias Engdegård
2023-01-05 12:55 ` Dmitry Gutov
2023-01-06 11:17 ` Mattias Engdegård
2023-01-06 21:41 ` Dmitry Gutov
2023-01-07 12:57 ` Mattias Engdegård
2023-01-08 21:48 ` Dmitry Gutov
2023-01-09 6:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 13:01 ` Dmitry Gutov
2023-01-05 0:02 ` Dmitry Gutov
2023-01-05 6:32 ` Eli Zaretskii
2023-01-05 12:49 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12687b52-fac4-adf9-a135-e203d1b8eb77@yandex.ru \
--to=dgutov@yandex.ru \
--cc=58950@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).