From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: serg.foo@gmail.com, dancol@dancol.org, 69952@debbugs.gnu.org
Subject: bug#69952: [PATCH] Support pdumping compiled queries by dumping their source
Date: Tue, 21 May 2024 23:36:47 -0700 [thread overview]
Message-ID: <61C9A0EB-D97D-4223-B257-FCA8DB150AA6@gmail.com> (raw)
In-Reply-To: <86wmnrecr0.fsf@gnu.org>
> On May 18, 2024, at 1:38 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> Ping!
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sat, 4 May 2024 14:29:06 -0700
>> Cc: serg.foo@gmail.com,
>> dancol@dancol.org,
>> 69952@debbugs.gnu.org
>>
>>
>>
>>> On May 4, 2024, at 2:39 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>
>>>> From: Yuan Fu <casouri@gmail.com>
>>>> Date: Sun, 21 Apr 2024 23:25:10 -0700
>>>> Cc: dancol@dancol.org,
>>>> serg.foo@gmail.com,
>>>> 69952@debbugs.gnu.org
>>>>
>>>>> On Apr 21, 2024, at 11:18 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>>>
>>>>>
>>>>> We cannot safely signal an error at that point, I think, so just
>>>>> keeping the query as a string should do, as it will then signal an
>>>>> error at run time when that query is used, is that right?
>>>>
>>>> Yes, most likely a function-undefined signal, since all the treesit.c functions like treesit-query-capture or treesit-query-compile will be nonexistent. And usually the Lisp program trying to use the query would check for tree-sitter availability with treesit-available-p before trying to use any tree-sitter functions; so that signal will be usually avoided as well.
>>>
>>> Can you suggest such an addition to the patch?
>>
>> Let me take a look.
>>
>> Yuan
Am I missing something? It seems the patch doesn’t include anything about loading a dumped query? I guess that’s the addition you’re talking about? If I want to add a special loader, where should I start?
Yuan
next prev parent reply other threads:[~2024-05-22 6:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 3:27 bug#69952: [PATCH] Support pdumping compiled queries by dumping their source Sergey Vinokurov
2024-03-23 7:08 ` Eli Zaretskii
2024-03-23 12:53 ` Sergey Vinokurov
2024-03-23 13:09 ` Eli Zaretskii
2024-04-13 7:41 ` Eli Zaretskii
2024-04-20 8:08 ` Yuan Fu
2024-04-20 9:32 ` Eli Zaretskii
2024-04-20 22:50 ` Yuan Fu
2024-04-21 4:53 ` Eli Zaretskii
2024-04-21 23:41 ` Yuan Fu
2024-04-22 5:47 ` Eli Zaretskii
2024-04-22 6:04 ` Yuan Fu
2024-04-22 6:18 ` Eli Zaretskii
2024-04-22 6:25 ` Yuan Fu
2024-05-04 9:39 ` Eli Zaretskii
2024-05-04 21:29 ` Yuan Fu
2024-05-18 8:38 ` Eli Zaretskii
2024-05-22 6:36 ` Yuan Fu [this message]
2024-05-22 12:55 ` Eli Zaretskii
2024-05-29 16:35 ` Andrea Corallo
2024-06-01 17:07 ` Yuan Fu
2024-06-15 7:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61C9A0EB-D97D-4223-B257-FCA8DB150AA6@gmail.com \
--to=casouri@gmail.com \
--cc=69952@debbugs.gnu.org \
--cc=dancol@dancol.org \
--cc=eliz@gnu.org \
--cc=serg.foo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).