From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: serg.foo@gmail.com, dancol@dancol.org, 69952@debbugs.gnu.org
Subject: bug#69952: [PATCH] Support pdumping compiled queries by dumping their source
Date: Sun, 21 Apr 2024 23:25:10 -0700 [thread overview]
Message-ID: <A8EA5E2A-9C8E-41A9-8AEC-59DE57220F7C@gmail.com> (raw)
In-Reply-To: <868r157wdy.fsf@gnu.org>
> On Apr 21, 2024, at 11:18 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sun, 21 Apr 2024 23:04:47 -0700
>> Cc: Daniel Colascione <dancol@dancol.org>,
>> serg.foo@gmail.com,
>> 69952@debbugs.gnu.org
>>
>>>> No. You need both tree-sitter library and the grammar library.
>>>
>>> That's what I thought. So starting Emacs in that case will attempt to
>>> call a function from the tree-sitter library, and will segfault,
>>> right? If so, we should have some protection in the code in
>>> pdumper.c that loads queries, which tests that tree-sitter is
>>> availabale, and if not does something to prevent the segfault, like
>>> not loading the query, perhaps?
>>
>> Right, it can use Ftreesit_available_p (we can define a C equivalent if pdumper can’t call lisp), and decide whether to compile the query or just keep the query as a string, or signal an error?
>
> We cannot safely signal an error at that point, I think, so just
> keeping the query as a string should do, as it will then signal an
> error at run time when that query is used, is that right?
Yes, most likely a function-undefined signal, since all the treesit.c functions like treesit-query-capture or treesit-query-compile will be nonexistent. And usually the Lisp program trying to use the query would check for tree-sitter availability with treesit-available-p before trying to use any tree-sitter functions; so that signal will be usually avoided as well.
Yuan
next prev parent reply other threads:[~2024-04-22 6:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 3:27 bug#69952: [PATCH] Support pdumping compiled queries by dumping their source Sergey Vinokurov
2024-03-23 7:08 ` Eli Zaretskii
2024-03-23 12:53 ` Sergey Vinokurov
2024-03-23 13:09 ` Eli Zaretskii
2024-04-13 7:41 ` Eli Zaretskii
2024-04-20 8:08 ` Yuan Fu
2024-04-20 9:32 ` Eli Zaretskii
2024-04-20 22:50 ` Yuan Fu
2024-04-21 4:53 ` Eli Zaretskii
2024-04-21 23:41 ` Yuan Fu
2024-04-22 5:47 ` Eli Zaretskii
2024-04-22 6:04 ` Yuan Fu
2024-04-22 6:18 ` Eli Zaretskii
2024-04-22 6:25 ` Yuan Fu [this message]
2024-05-04 9:39 ` Eli Zaretskii
2024-05-04 21:29 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A8EA5E2A-9C8E-41A9-8AEC-59DE57220F7C@gmail.com \
--to=casouri@gmail.com \
--cc=69952@debbugs.gnu.org \
--cc=dancol@dancol.org \
--cc=eliz@gnu.org \
--cc=serg.foo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).