From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: serg.foo@gmail.com, Daniel Colascione <dancol@dancol.org>,
69952@debbugs.gnu.org
Subject: bug#69952: [PATCH] Support pdumping compiled queries by dumping their source
Date: Sat, 20 Apr 2024 15:50:36 -0700 [thread overview]
Message-ID: <9B2A2190-AB42-4F1B-9F9D-5623B343CF0A@gmail.com> (raw)
In-Reply-To: <861q709y5y.fsf@gnu.org>
> On Apr 20, 2024, at 2:32 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Sat, 20 Apr 2024 01:08:15 -0700
>> Cc: dancol@dancol.org,
>> serg.foo@gmail.com,
>> 69952@debbugs.gnu.org
>>
>>
>>
>>> On Apr 13, 2024, at 12:41 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>>>>
>>>> And I have a question: what happens if the pdumper file dumped with
>>>> tree-sitter available is loaded by an Emacs session in which
>>>> tree-sitter is not available? That can happen on Windows, for
>>>> example, if the tree-sitter library or the grammar library required
>>>> for recomputing the query is not available. I think we need some code
>>>> to prevent Emacs from crashing on startup in that case.
>>
>> Yeah, being able to dump queries is certainly nice. There will be problems if the Emacs session that later loads the query either have a different grammar version loaded, or a difference grammar library for the same language, or outright doesn’t have tree-sitter like Eli mentioned. I don’t know if they are big enough problems to give up dumping queries, though.
>
> Giving up: no. But I think the code which loads the queries from the
> pdumper file should be protected from crashing in those cases. Can
> you suggest how to do that?
Would Emacs crash? If the dump file just contains the query (which is a string), then Emacs would just compile the query with treesit-query-compile, it could fail (due to the reasons I mentioned), but shouldn’t crash Emacs.
Yuan
next prev parent reply other threads:[~2024-04-20 22:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 3:27 bug#69952: [PATCH] Support pdumping compiled queries by dumping their source Sergey Vinokurov
2024-03-23 7:08 ` Eli Zaretskii
2024-03-23 12:53 ` Sergey Vinokurov
2024-03-23 13:09 ` Eli Zaretskii
2024-04-13 7:41 ` Eli Zaretskii
2024-04-20 8:08 ` Yuan Fu
2024-04-20 9:32 ` Eli Zaretskii
2024-04-20 22:50 ` Yuan Fu [this message]
2024-04-21 4:53 ` Eli Zaretskii
2024-04-21 23:41 ` Yuan Fu
2024-04-22 5:47 ` Eli Zaretskii
2024-04-22 6:04 ` Yuan Fu
2024-04-22 6:18 ` Eli Zaretskii
2024-04-22 6:25 ` Yuan Fu
2024-05-04 9:39 ` Eli Zaretskii
2024-05-04 21:29 ` Yuan Fu
2024-05-18 8:38 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9B2A2190-AB42-4F1B-9F9D-5623B343CF0A@gmail.com \
--to=casouri@gmail.com \
--cc=69952@debbugs.gnu.org \
--cc=dancol@dancol.org \
--cc=eliz@gnu.org \
--cc=serg.foo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).