From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#22241: 25.0.50; etags Ruby parser problems Date: Tue, 2 Feb 2016 22:59:35 +0300 Message-ID: <56B10AA7.5000103@yandex.ru> References: <86r3i9hnbt.fsf@yandex.ru> <83si1o45g1.fsf@gnu.org> <56A3C53D.1050408@yandex.ru> <83oacc3yx7.fsf@gnu.org> <56A3D47E.3030802@yandex.ru> <83mvrw3tuj.fsf@gnu.org> <56A3F3F9.8030404@yandex.ru> <8360yj3rtf.fsf@gnu.org> <83k2mrw952.fsf@gnu.org> <56AD33CF.6060105@yandex.ru> <83h9hu4dy8.fsf@gnu.org> <56AD9EF3.3080104@yandex.ru> <83powh1uwh.fsf@gnu.org> <56AF1A0E.7080802@yandex.ru> <8360y7yo3y.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1454443226 7932 80.91.229.3 (2 Feb 2016 20:00:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Feb 2016 20:00:26 +0000 (UTC) Cc: 22241@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 02 21:00:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aQh7U-0003oB-GH for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Feb 2016 21:00:12 +0100 Original-Received: from localhost ([::1]:59238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQh7T-0000FL-IK for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Feb 2016 15:00:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQh7Q-0000El-3t for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 15:00:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQh7K-00086Z-Em for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 15:00:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQh7K-00086V-Ba for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 15:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aQh7K-0001iT-6H for bug-gnu-emacs@gnu.org; Tue, 02 Feb 2016 15:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Feb 2016 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22241-submit@debbugs.gnu.org id=B22241.14544431856548 (code B ref 22241); Tue, 02 Feb 2016 20:00:02 +0000 Original-Received: (at 22241) by debbugs.gnu.org; 2 Feb 2016 19:59:45 +0000 Original-Received: from localhost ([127.0.0.1]:57103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQh73-0001hY-9X for submit@debbugs.gnu.org; Tue, 02 Feb 2016 14:59:45 -0500 Original-Received: from mail-lb0-f177.google.com ([209.85.217.177]:34458) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aQh70-0001hE-U8 for 22241@debbugs.gnu.org; Tue, 02 Feb 2016 14:59:43 -0500 Original-Received: by mail-lb0-f177.google.com with SMTP id cw1so8007638lbb.1 for <22241@debbugs.gnu.org>; Tue, 02 Feb 2016 11:59:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=mdzWSXLWlG49ouwDftrlPF3CqKmfVwhtydxPUuziq5Q=; b=uOYbCw5qssEGEg9B1IitRH0Vr1WD1VWiEsNZYsw8H5kAVr5dG4Y/D8I6TK+b1x9i94 G0x6lORy4/jCWeszHcuPeesqH9WASErzwMgP3HrPtWy65g7eQ3LNRDimn9OSwPlhSGTE YygQs7+QUkBYIWA0vlvB7uUriKgomJgqmFqPgYH3PJIr2v+dYOaAtbUybhnI8ArWXKJv V66ibw3YlsLaQJYvdaFZKHWDRRZdge7j7OjE+vcvVjaVsbb+qvmd9qj4Zf3uOClnuHMA PKXic1MocLaBPanK1jP4Xl/uiWJGxpnEdgvBM70eZzDL9mYV5G5RO6o2H2/44AlaarEy miiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=mdzWSXLWlG49ouwDftrlPF3CqKmfVwhtydxPUuziq5Q=; b=ZGTTjKqDHFzHVuEEgXT7DzDy+mL+ZgRC8niwrFrQoJHZ88i/VgAEREV0B1ni41atX/ wCRGQeTmzW7tstYOmgw+b9Yqgvib8B9V0Y1GA5xzCSE6kVa1goQn7TvzaOOL1HgBqfkG Et/qd2qFZakwWEq3RQ3K+C8H1UyzQ3pKpveYvxeaKohJ7zy6bwj9NQI/5vExmOYdH+NT 3AkoPVNBsqi2ffyOHstRXYihsHPOIvHQJloWWwxIzgaetq42kfCUZXYzc3gjiYoa3dkL wE+Hf8wkX4NqjRKowQhrsx1UyE9ToZ30WSFh51ChoTGyQ45HMxG78UqzAkU3KjGN18uD uteQ== X-Gm-Message-State: AG10YOTK1HGWUEKcWZsmVfGQLVCV2G7SM+RQUmJIERAbS5EW9Y4ckE1l/MQ3npXkc6PkWA== X-Received: by 10.112.140.195 with SMTP id ri3mr11888354lbb.136.1454443176924; Tue, 02 Feb 2016 11:59:36 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id jr10sm427977lbc.42.2016.02.02.11.59.35 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 02 Feb 2016 11:59:35 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: <8360y7yo3y.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112289 Archived-At: On 02/02/2016 09:16 PM, Eli Zaretskii wrote: >> So you would handle >> >> attr_WHATEVER :foo, :bar # comment >> >> and probably >> >> attr_WHATEVER :bar; > OK, this is all implemented, except... Thank you. >> If there's a comma at the end of the current line, the argument list >> continues on the next one. > > ...this. If supporting such split definitions is important, it will > need a slightly more complex code. It's basically a multiline function call. Not sure how frequently that is used with attr_* in practice, but in our big project at work, just one out of 190 attr_* declarations is multiline. So, it happens, but in the vast majority of cases the arguments stay on one line. Some projects (like Rails) choose to make several calls instead, as a stylistic choice. I can't really say yet if the lack of support for multiline calls is a significant problem, but it is an omission. Whether to implement it now, or close this bug and wait until another bug report, is up to you. >> .rb .ru .rbw Rakefile Thorfile > > Also done (and doing so exposed a real bug in etags). Thanks! Looks good.