From: Dmitry Gutov <dgutov@yandex.ru>
To: Wolfgang Jenkner <wjenkner@inode.at>, 21067@debbugs.gnu.org
Subject: bug#21067: 25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob
Date: Sun, 19 Jul 2015 03:08:28 +0300 [thread overview]
Message-ID: <55AAEA7C.2060609@yandex.ru> (raw)
In-Reply-To: <85lheh8ekr.fsf@iznogoud.viz>
On 07/15/2015 02:09 PM, Wolfgang Jenkner wrote:
> So I wonder whether it wouldn't be worthwile to make their job easier
> (and thereby avoid bugs like the one described above) by handling async
> and sync processes alike in this respect. The condition for this to
> work is that backend functions don't expect point to be preserved,
> except, of course, if it is actually their purpose to compute point
> (like for vc-git-show-log-entry).
I like the idea, but FWIW the patch breaks diff-hl-revert-hunk (diff-hl
is in GNU ELPA). Haven't investigated it further yet.
And the particular bug you've described, naturally, can also be fixed by
making vc-hg-print-log asynchronous:
diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index 556174a..f634e2e 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -272,7 +272,7 @@ If LIMIT is non-nil, show no more than this many
entries."
(let ((inhibit-read-only t))
(with-current-buffer
buffer
- (apply 'vc-hg-command buffer 0 files "log"
+ (apply 'vc-hg-command buffer 'async files "log"
(nconc
(when start-revision (list (format "-r%s:0" start-revision)))
(when limit (list "-l" (format "%s" limit)))
next prev parent reply other threads:[~2015-07-19 0:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 11:09 bug#21067: 25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob Wolfgang Jenkner
2015-07-19 0:08 ` Dmitry Gutov [this message]
2015-07-19 1:36 ` Wolfgang Jenkner
2015-07-19 11:05 ` Dmitry Gutov
2015-07-19 18:04 ` Dmitry Gutov
2015-07-24 14:14 ` Dmitry Gutov
2015-11-30 3:01 ` Dmitry Gutov
2021-05-10 11:28 ` Lars Ingebrigtsen
2021-05-10 11:57 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AAEA7C.2060609@yandex.ru \
--to=dgutov@yandex.ru \
--cc=21067@debbugs.gnu.org \
--cc=wjenkner@inode.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).