From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#21067: 25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob Date: Sun, 19 Jul 2015 03:08:28 +0300 Message-ID: <55AAEA7C.2060609@yandex.ru> References: <85lheh8ekr.fsf@iznogoud.viz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1437264562 8355 80.91.229.3 (19 Jul 2015 00:09:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 19 Jul 2015 00:09:22 +0000 (UTC) To: Wolfgang Jenkner , 21067@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 19 02:09:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZGcAJ-0006PM-0Q for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Jul 2015 02:09:11 +0200 Original-Received: from localhost ([::1]:50161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGcAH-0008Cj-TR for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Jul 2015 20:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGcAD-00089r-UW for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2015 20:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGcAA-0000uU-Nr for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2015 20:09:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGcAA-0000uQ-K9 for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2015 20:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZGcAA-0001rg-AR for bug-gnu-emacs@gnu.org; Sat, 18 Jul 2015 20:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Jul 2015 00:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21067-submit@debbugs.gnu.org id=B21067.14372645217129 (code B ref 21067); Sun, 19 Jul 2015 00:09:02 +0000 Original-Received: (at 21067) by debbugs.gnu.org; 19 Jul 2015 00:08:41 +0000 Original-Received: from localhost ([127.0.0.1]:53413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZGc9p-0001qu-2A for submit@debbugs.gnu.org; Sat, 18 Jul 2015 20:08:41 -0400 Original-Received: from mail-wg0-f51.google.com ([74.125.82.51]:36847) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZGc9m-0001qd-Pt for 21067@debbugs.gnu.org; Sat, 18 Jul 2015 20:08:39 -0400 Original-Received: by wgbcc4 with SMTP id cc4so12912974wgb.3 for <21067@debbugs.gnu.org>; Sat, 18 Jul 2015 17:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=tp1+XgNOwq6lgbaKN0EfeJSy1WoxK0bQKXvGWDvW2BM=; b=HJRHRLy7wLt2riYUz5LRC+ECOEo6oF//QK3WvEQaUD5K50fRISWFAB6A1acMqUjB5k aAsRcH4kdAzDPzNtPdDTD1DDCospMvzBFBuuuWWX8WXV60gMQxaQqSWDmtqGphWHHHi7 Fwb98oW2C2kWqUHUajVAbY/1jk+WlijIoJaIIUtDgLsI4y4l/RFLJ5rtEZXItu38lO0A ZtkSOESWjUQDI/GYzYNzegv4Uzr8SMg6oebwJxsUi2Cg/9Y0pw3M+T9d1IV1HQN94KN4 VsTIaRCPWq49tMXyJWfO/YFHK5NLbTdRp2WTAekD9TD4LhQEJmAVoHU9mHXhIiS+qYnM Zyxw== X-Received: by 10.180.9.6 with SMTP id v6mr8370993wia.83.1437264513282; Sat, 18 Jul 2015 17:08:33 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id k2sm4767123wif.4.2015.07.18.17.08.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 18 Jul 2015 17:08:32 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 In-Reply-To: <85lheh8ekr.fsf@iznogoud.viz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105032 Archived-At: On 07/15/2015 02:09 PM, Wolfgang Jenkner wrote: > So I wonder whether it wouldn't be worthwile to make their job easier > (and thereby avoid bugs like the one described above) by handling async > and sync processes alike in this respect. The condition for this to > work is that backend functions don't expect point to be preserved, > except, of course, if it is actually their purpose to compute point > (like for vc-git-show-log-entry). I like the idea, but FWIW the patch breaks diff-hl-revert-hunk (diff-hl is in GNU ELPA). Haven't investigated it further yet. And the particular bug you've described, naturally, can also be fixed by making vc-hg-print-log asynchronous: diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el index 556174a..f634e2e 100644 --- a/lisp/vc/vc-hg.el +++ b/lisp/vc/vc-hg.el @@ -272,7 +272,7 @@ If LIMIT is non-nil, show no more than this many entries." (let ((inhibit-read-only t)) (with-current-buffer buffer - (apply 'vc-hg-command buffer 0 files "log" + (apply 'vc-hg-command buffer 'async files "log" (nconc (when start-revision (list (format "-r%s:0" start-revision))) (when limit (list "-l" (format "%s" limit)))