From: Dmitry Gutov <dgutov@yandex.ru>
To: Wolfgang Jenkner <wjenkner@inode.at>
Cc: 21067@debbugs.gnu.org
Subject: bug#21067: 25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob
Date: Sun, 19 Jul 2015 14:05:04 +0300 [thread overview]
Message-ID: <55AB8460.6080707@yandex.ru> (raw)
In-Reply-To: <85380ludu0.fsf@iznogoud.viz>
On 07/19/2015 04:36 AM, Wolfgang Jenkner wrote:
> If I read diff-hl-revert-hunk correctly the code in vc-exec-after
> expects point where (the synchronous call to) vc-diff-internal left it,
> which should not be at eob, which is exactly where my patch would put
> it :-(
It's not hard to fix, though: (goto-char (point-min)) at the beginning
of vc-exec-after block there should do it. That would be
backward-compatible, so I'm perfectly willing to make that change.
> It seems some code (not so far) out there uses synchronous calls for
> a reason and also does much more weird things in vc-exec-after than I'd
> have thought.
There are not too many third-party packages that integrate with VC, so
one could go over them and check for similar assumptions. Your patch
does make a certain amount of sense.
> If all -print-log backend functions can be made asynchronous there's
> nothing left to fix in the frontend I guess...
They can, but a similar problem could conceivably arise with something
other than print-log.
On the other hand, the long-term target is to make all VC calls
asynchronous. So maybe we can take the easy way out in fixing the
present bug.
next prev parent reply other threads:[~2015-07-19 11:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 11:09 bug#21067: 25.0.50; [PATCH] With mercurial, vc-print-log puts point at eob Wolfgang Jenkner
2015-07-19 0:08 ` Dmitry Gutov
2015-07-19 1:36 ` Wolfgang Jenkner
2015-07-19 11:05 ` Dmitry Gutov [this message]
2015-07-19 18:04 ` Dmitry Gutov
2015-07-24 14:14 ` Dmitry Gutov
2015-11-30 3:01 ` Dmitry Gutov
2021-05-10 11:28 ` Lars Ingebrigtsen
2021-05-10 11:57 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AB8460.6080707@yandex.ru \
--to=dgutov@yandex.ru \
--cc=21067@debbugs.gnu.org \
--cc=wjenkner@inode.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).