unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#14787: 24.3, M-x query-replace - useless warning
@ 2013-07-04  8:22 Andreas Röhler
  2013-07-04  8:36 ` Andreas Schwab
  0 siblings, 1 reply; 14+ messages in thread
From: Andreas Röhler @ 2013-07-04  8:22 UTC (permalink / raw)
  To: 14787

M-x query-replace RET ] RET

sends a warning

"No matching parenthesis found"

which seems useful only WRT to regexps.

See also

http://stackoverflow.com/questions/17464676/emacs-replace-right-square-bracket/17465200#17465200





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-04  8:22 bug#14787: 24.3, M-x query-replace - useless warning Andreas Röhler
@ 2013-07-04  8:36 ` Andreas Schwab
  2013-07-04 13:18   ` Andreas Röhler
  0 siblings, 1 reply; 14+ messages in thread
From: Andreas Schwab @ 2013-07-04  8:36 UTC (permalink / raw)
  To: Andreas Röhler; +Cc: 14787

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

> M-x query-replace RET ] RET
>
> sends a warning
>
> "No matching parenthesis found"
>
> which seems useful only WRT to regexps.

This has nothing to do with regexps.  Show Paren mode is a global minor
mode that is enabled independent of the context.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-04  8:36 ` Andreas Schwab
@ 2013-07-04 13:18   ` Andreas Röhler
  2013-07-04 14:55     ` Tassilo Horn
  0 siblings, 1 reply; 14+ messages in thread
From: Andreas Röhler @ 2013-07-04 13:18 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: 14787

Am 04.07.2013 10:36, schrieb Andreas Schwab:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>> M-x query-replace RET ] RET
>>
>> sends a warning
>>
>> "No matching parenthesis found"
>>
>> which seems useful only WRT to regexps.
>
> This has nothing to do with regexps.  Show Paren mode is a global minor
> mode that is enabled independent of the context.
>
> Andreas.
>

It also happens if show-paren-mode is nil.
Don't see it related.





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-04 13:18   ` Andreas Röhler
@ 2013-07-04 14:55     ` Tassilo Horn
  2013-07-04 19:21       ` Andreas Röhler
  0 siblings, 1 reply; 14+ messages in thread
From: Tassilo Horn @ 2013-07-04 14:55 UTC (permalink / raw)
  To: Andreas Röhler; +Cc: Andreas Schwab, 14787

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

>>> M-x query-replace RET ] RET
>>>
>>> sends a warning
>>>
>>> "No matching parenthesis found"
>>>
>>> which seems useful only WRT to regexps.
>>
>> This has nothing to do with regexps.  Show Paren mode is a global minor
>> mode that is enabled independent of the context.
>
> It also happens if show-paren-mode is nil.
> Don't see it related.

It actually depends on `blink-matching-paren', not `show-paren-mode'.

Bye,
Tassilo





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-04 14:55     ` Tassilo Horn
@ 2013-07-04 19:21       ` Andreas Röhler
  2013-07-05  7:45         ` Tassilo Horn
  0 siblings, 1 reply; 14+ messages in thread
From: Andreas Röhler @ 2013-07-04 19:21 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: Andreas Schwab, 14787

Am 04.07.2013 16:55, schrieb Tassilo Horn:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>>>> M-x query-replace RET ] RET
>>>>
>>>> sends a warning
>>>>
>>>> "No matching parenthesis found"
>>>>
>>>> which seems useful only WRT to regexps.
>>>
>>> This has nothing to do with regexps.  Show Paren mode is a global minor
>>> mode that is enabled independent of the context.
>>
>> It also happens if show-paren-mode is nil.
>> Don't see it related.
>
> It actually depends on `blink-matching-paren', not `show-paren-mode'.
>
> Bye,
> Tassilo
>

Okay, thanks. IMO it's a bug nonetheless, it's a warning which might confuse users.

Cheers,

Andreas





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-04 19:21       ` Andreas Röhler
@ 2013-07-05  7:45         ` Tassilo Horn
  2013-07-05  7:54           ` martin rudalics
  2013-07-05 19:38           ` Andreas Röhler
  0 siblings, 2 replies; 14+ messages in thread
From: Tassilo Horn @ 2013-07-05  7:45 UTC (permalink / raw)
  To: Andreas Röhler; +Cc: Andreas Schwab, 14787

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

>>>> This has nothing to do with regexps.  Show Paren mode is a global
>>>> minor mode that is enabled independent of the context.
>>>
>>> It also happens if show-paren-mode is nil.  Don't see it related.
>>
>> It actually depends on `blink-matching-paren', not `show-paren-mode'.
>
> Okay, thanks. IMO it's a bug nonetheless, it's a warning which might
> confuse users.

Not sure, IMHO "balanced" replacements like \(foo\|bar\) -> [\1] are
more common, and then `blink-matching-paren' makes sense.  I mean, what
are the alternatives?  We could disable `blink-matching-paren' when
reading from the minibuffer altogether, or have another defcustom
`blink-matching-paren-in-minibuffer' for controlling that behavior, and
then, what should its default value be?

Bye,
Tassilo





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-05  7:45         ` Tassilo Horn
@ 2013-07-05  7:54           ` martin rudalics
  2013-07-05 19:38           ` Andreas Röhler
  1 sibling, 0 replies; 14+ messages in thread
From: martin rudalics @ 2013-07-05  7:54 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: Andreas Schwab, 14787

 > Not sure, IMHO "balanced" replacements like \(foo\|bar\) -> [\1] are
 > more common, and then `blink-matching-paren' makes sense.  I mean, what
 > are the alternatives?  We could disable `blink-matching-paren' when
 > reading from the minibuffer altogether, or have another defcustom
 > `blink-matching-paren-in-minibuffer' for controlling that behavior, and
 > then, what should its default value be?

We could disable `blink-matching-paren' by default ;-)

martin





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-05  7:45         ` Tassilo Horn
  2013-07-05  7:54           ` martin rudalics
@ 2013-07-05 19:38           ` Andreas Röhler
  2013-07-05 22:10             ` Juri Linkov
  2013-07-08  8:30             ` Tassilo Horn
  1 sibling, 2 replies; 14+ messages in thread
From: Andreas Röhler @ 2013-07-05 19:38 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: Andreas Schwab, 14787

Am 05.07.2013 09:45, schrieb Tassilo Horn:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>>>>> This has nothing to do with regexps.  Show Paren mode is a global
>>>>> minor mode that is enabled independent of the context.
>>>>
>>>> It also happens if show-paren-mode is nil.  Don't see it related.
>>>
>>> It actually depends on `blink-matching-paren', not `show-paren-mode'.
>>
>> Okay, thanks. IMO it's a bug nonetheless, it's a warning which might
>> confuse users.
>
> Not sure, IMHO "balanced" replacements like \(foo\|bar\) -> [\1] are
> more common,

It's about query-replace, not query-replace-regexp

Cheers,

Andreas

and then `blink-matching-paren' makes sense.  I mean, what
> are the alternatives?  We could disable `blink-matching-paren' when
> reading from the minibuffer altogether, or have another defcustom
> `blink-matching-paren-in-minibuffer' for controlling that behavior, and
> then, what should its default value be?
>
> Bye,
> Tassilo
>






^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-05 19:38           ` Andreas Röhler
@ 2013-07-05 22:10             ` Juri Linkov
  2013-07-06  6:17               ` Andreas Röhler
  2013-07-08  8:30             ` Tassilo Horn
  1 sibling, 1 reply; 14+ messages in thread
From: Juri Linkov @ 2013-07-05 22:10 UTC (permalink / raw)
  To: Andreas Röhler; +Cc: Andreas Schwab, 14787, Tassilo Horn

>>>> It actually depends on `blink-matching-paren', not `show-paren-mode'.
>>>
>>> Okay, thanks. IMO it's a bug nonetheless, it's a warning which might
>>> confuse users.
>>
>> Not sure, IMHO "balanced" replacements like \(foo\|bar\) -> [\1] are
>> more common,
>
> It's about query-replace, not query-replace-regexp

You can make balanced non-regexp replacements in query-replace like
(foo (bar)) -> (bar (foo))

The warning "No matching parenthesis found" helps the users to write
correctly balanced expressions everywhere, including minibuffers.
When you sometimes write an unbalanced expression intentionally,
you can ignore this warning.





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-05 22:10             ` Juri Linkov
@ 2013-07-06  6:17               ` Andreas Röhler
  2013-07-06  7:20                 ` Andreas Schwab
  0 siblings, 1 reply; 14+ messages in thread
From: Andreas Röhler @ 2013-07-06  6:17 UTC (permalink / raw)
  To: Juri Linkov; +Cc: Andreas Schwab, 14787, Tassilo Horn

Am 06.07.2013 00:10, schrieb Juri Linkov:
>>>>> It actually depends on `blink-matching-paren', not `show-paren-mode'.
>>>>
>>>> Okay, thanks. IMO it's a bug nonetheless, it's a warning which might
>>>> confuse users.
>>>
>>> Not sure, IMHO "balanced" replacements like \(foo\|bar\) -> [\1] are
>>> more common,
>>
>> It's about query-replace, not query-replace-regexp
>
> You can make balanced non-regexp replacements in query-replace like
> (foo (bar)) -> (bar (foo))
>
> The warning "No matching parenthesis found" helps the users to write
> correctly balanced expressions everywhere, including minibuffers.
> When you sometimes write an unbalanced expression intentionally,
> you can ignore this warning.
>

A help should not go in the way. When writing code, this help is useful.
When replacing single chars, not.

Andreas








^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-06  6:17               ` Andreas Röhler
@ 2013-07-06  7:20                 ` Andreas Schwab
  2013-07-06 10:24                   ` Andreas Röhler
  0 siblings, 1 reply; 14+ messages in thread
From: Andreas Schwab @ 2013-07-06  7:20 UTC (permalink / raw)
  To: Andreas Röhler; +Cc: 14787, Tassilo Horn

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

> A help should not go in the way. When writing code, this help is useful.
> When replacing single chars, not.

How will the minibuffer know that you intent to input only a single
character?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-06  7:20                 ` Andreas Schwab
@ 2013-07-06 10:24                   ` Andreas Röhler
  0 siblings, 0 replies; 14+ messages in thread
From: Andreas Röhler @ 2013-07-06 10:24 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: 14787, Tassilo Horn

Am 06.07.2013 09:20, schrieb Andreas Schwab:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>> A help should not go in the way. When writing code, this help is useful.
>> When replacing single chars, not.
>
> How will the minibuffer know that you intent to input only a single
> character?
>
> Andreas.
>

So let's extend the single character to a string, which should make the issue more obvious.





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-05 19:38           ` Andreas Röhler
  2013-07-05 22:10             ` Juri Linkov
@ 2013-07-08  8:30             ` Tassilo Horn
  2013-07-08 14:20               ` Andreas Röhler
  1 sibling, 1 reply; 14+ messages in thread
From: Tassilo Horn @ 2013-07-08  8:30 UTC (permalink / raw)
  To: Andreas Röhler; +Cc: Andreas Schwab, 14787

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

>> Not sure, IMHO "balanced" replacements like \(foo\|bar\) -> [\1] are
>> more common,
>
> It's about query-replace, not query-replace-regexp

You get that warning nearly everywhere something is read from the
minibuffer, e.g., also with `search-forward',
`execute-extended-command', `find-file', etc.

Well, at least for the latter two, `blink-matching-paren' doesn't really
make much sense, but then again, it's unlikely a user enters just a
closing paren when he wants to execute a command or find a file.

Bye,
Tassilo





^ permalink raw reply	[flat|nested] 14+ messages in thread

* bug#14787: 24.3, M-x query-replace - useless warning
  2013-07-08  8:30             ` Tassilo Horn
@ 2013-07-08 14:20               ` Andreas Röhler
  0 siblings, 0 replies; 14+ messages in thread
From: Andreas Röhler @ 2013-07-08 14:20 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: Andreas Schwab, 14787

Am 08.07.2013 10:30, schrieb Tassilo Horn:
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>>> Not sure, IMHO "balanced" replacements like \(foo\|bar\) -> [\1] are
>>> more common,
>>
>> It's about query-replace, not query-replace-regexp
>
> You get that warning nearly everywhere something is read from the
> minibuffer, e.g., also with `search-forward',
> `execute-extended-command', `find-file', etc.
>
> Well, at least for the latter two, `blink-matching-paren' doesn't really
> make much sense, but then again, it's unlikely a user enters just a
> closing paren when he wants to execute a command or find a file.
>
> Bye,
> Tassilo
>

Indeed, bug exists also WRT search-forward.

Cheers,

Andreas








^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2013-07-08 14:20 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-04  8:22 bug#14787: 24.3, M-x query-replace - useless warning Andreas Röhler
2013-07-04  8:36 ` Andreas Schwab
2013-07-04 13:18   ` Andreas Röhler
2013-07-04 14:55     ` Tassilo Horn
2013-07-04 19:21       ` Andreas Röhler
2013-07-05  7:45         ` Tassilo Horn
2013-07-05  7:54           ` martin rudalics
2013-07-05 19:38           ` Andreas Röhler
2013-07-05 22:10             ` Juri Linkov
2013-07-06  6:17               ` Andreas Röhler
2013-07-06  7:20                 ` Andreas Schwab
2013-07-06 10:24                   ` Andreas Röhler
2013-07-08  8:30             ` Tassilo Horn
2013-07-08 14:20               ` Andreas Röhler

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).