From: Tim Crews <tim.crews@code-affinity.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 9960@debbugs.gnu.org
Subject: bug#9960: Compiling Emacs trunk with MSVC
Date: Wed, 30 Nov 2011 12:42:08 -0700 [thread overview]
Message-ID: <4ED68710.5020304@code-affinity.com> (raw)
In-Reply-To: <83y5ux4dya.fsf@gnu.org>
On 11/30/2011 12:17 PM, Eli Zaretskii wrote:
>> Date: Wed, 30 Nov 2011 11:22:05 -0700
>> From: Tim Crews<tim.crews@code-affinity.com>
>> Cc: 9960@debbugs.gnu.org
>>
>>> If you tried a 64-bit build, then it is not yet supported on Windows.
>>> Try the 32-bit build, it should work.
>>
>> I was doing a 32-bit build. There are still a few minor changes from
>> Fabrice Popineau that haven't made it into bzr yet.
>> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9960#224) With those
>> changes, the build succeeds.
>
> Which changes, specifically, are needed? I know only about one issue:
> the one with _tzname. The rest, to the best of my knowledge, are for
> a 64-bit build. If I'm wrong, I'd like to know which other changes
> are still needed for the 32-bit build with MSVC.
>
>> I built from the latest bzr source and can confirm that the linum-mode
>> crash no longer occurs on my end.
>
> Thanks.
There are only two changes listed in but 9960 message 224, both related
to _tzname. (The patch is repeated for reference at the bottom of this
message.) The changes are to lib/strftime.c and src/s/ms-w32.h.
If I back out Fabrice's proposed change to lib/strftime.c, the build
succeeds through the compilation phase but fails to link because of
unresolved external _tzname.
If I back out Fabrice's proposed change to src/s/ms-w32.h, compilation
of ntlib.c fails with "time.h(270) : error C2090: function returns array".
So it appears that both changes are needed for the MSVC 32-bit build.
Tim Crews
=== modified file 'lib/strftime.c'
--- lib/strftime.c 2011-03-31 04:24:03 +0000
+++ lib/strftime.c 2011-11-28 15:38:55 +0000
@@ -36,9 +36,13 @@
#include <ctype.h>
#include <time.h>
+#ifdef _MSC_VER
+#define tzname _tzname
+#else
#if HAVE_TZNAME && !HAVE_DECL_TZNAME
extern char *tzname[];
#endif
+#endif
/* Do multibyte processing if multibytes are supported, unless
multibyte sequences are safe in formats. Multibyte sequences are
=== modified file 'src/s/ms-w32.h'
--- src/s/ms-w32.h 2011-11-27 18:52:53 +0000
+++ src/s/ms-w32.h 2011-11-28 15:33:33 +0000
@@ -286,7 +286,9 @@
#define stricmp _stricmp
#define tzset _tzset
+#ifndef _MSC_VER
#define tzname _tzname
+#endif
#if !defined (_MSC_VER) || (_MSC_VER < 1400)
#undef utime
#define utime _utime
prev parent reply other threads:[~2011-11-30 19:42 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <loom.20101206T214649-301@post.gmane.org>
[not found] ` <83sjy5279e.fsf@gnu.org>
[not found] ` <AANLkTikmhiNmd5gz8wkpqbgHni2LKkjhTtnPizaOEz7T@mail.gmail.com>
2011-11-05 11:19 ` bug#9960: Compiling Emacs trunk with MSVC Eli Zaretskii
2011-11-05 11:39 ` Eli Zaretskii
2011-11-05 12:54 ` Christoph Scholtes
2011-11-05 13:22 ` Eli Zaretskii
2011-11-05 13:58 ` Christoph Scholtes
2011-11-05 14:16 ` Eli Zaretskii
2011-11-05 14:53 ` Eli Zaretskii
2011-11-05 15:51 ` Óscar Fuentes
2011-11-05 16:10 ` Eli Zaretskii
2011-11-05 16:27 ` Christoph Scholtes
2011-11-05 16:50 ` Eli Zaretskii
2011-11-05 16:57 ` Eli Zaretskii
2011-11-05 17:22 ` Christoph Scholtes
2011-11-05 18:20 ` Christoph Scholtes
2011-11-05 19:33 ` Eli Zaretskii
2011-11-05 20:38 ` Christoph Scholtes
2011-11-05 21:11 ` Eli Zaretskii
2011-11-05 22:07 ` Christoph Scholtes
2011-11-05 22:15 ` Christoph Scholtes
2011-11-05 22:22 ` Christoph Scholtes
2011-11-06 4:03 ` Eli Zaretskii
2011-11-05 20:32 ` Christoph Scholtes
2011-11-05 21:27 ` Eli Zaretskii
2011-11-05 22:23 ` Christoph Scholtes
2011-11-06 1:50 ` Christoph Scholtes
2011-11-06 5:47 ` Eli Zaretskii
2011-11-06 5:37 ` Eli Zaretskii
2011-11-07 16:13 ` Fabrice Popineau
2011-11-07 16:57 ` Eli Zaretskii
[not found] ` <CAFgFV9N4w+wi4J84BhoEZrgAuwJdFZtWzOAkdb_T9+B7L+Ftfg@mail.gmail.com>
2011-11-08 16:51 ` Eli Zaretskii
2011-11-07 17:03 ` Eli Zaretskii
2011-11-10 19:56 ` Fabrice Popineau
2011-11-10 20:28 ` Lennart Borgman
2011-11-10 20:31 ` Juanma Barranquero
2011-11-10 20:29 ` Juanma Barranquero
2011-11-20 20:59 ` Fabrice Popineau
2011-11-20 21:15 ` Juanma Barranquero
2011-11-20 21:35 ` Dan Nicolaescu
2011-11-20 21:40 ` Juanma Barranquero
2011-11-21 2:30 ` Stefan Monnier
2011-11-21 2:45 ` Juanma Barranquero
2011-11-21 3:51 ` Eli Zaretskii
2011-11-21 8:21 ` Andreas Schwab
2011-11-21 9:54 ` Eli Zaretskii
2011-11-21 12:14 ` Juanma Barranquero
2011-11-21 13:56 ` Eli Zaretskii
2011-12-04 8:06 ` Fabrice Popineau
2011-12-05 5:11 ` Eli Zaretskii
2011-11-21 15:55 ` Richard Stallman
2011-11-11 9:39 ` Eli Zaretskii
2011-11-11 19:28 ` Fabrice Popineau
2011-11-11 19:53 ` Eli Zaretskii
2011-11-11 21:55 ` Fabrice Popineau
2011-11-12 13:50 ` Eli Zaretskii
2011-11-12 14:34 ` Fabrice Popineau
2011-11-12 15:59 ` Óscar Fuentes
2011-11-12 23:32 ` Richard Stallman
2011-11-12 14:27 ` Eli Zaretskii
2011-11-12 17:55 ` Fabrice Popineau
2011-11-12 20:48 ` Eli Zaretskii
2011-11-12 22:27 ` Fabrice Popineau
2011-11-12 22:44 ` Fabrice Popineau
2011-11-12 23:08 ` Fabrice Popineau
2011-11-13 14:45 ` Christoph Scholtes
2011-11-27 19:05 ` Eli Zaretskii
2011-11-28 9:18 ` YAMAMOTO Mitsuharu
2011-11-28 11:51 ` Eli Zaretskii
2011-11-28 19:07 ` Fabrice Popineau
2012-03-24 13:46 ` Eli Zaretskii
2012-03-24 16:10 ` Fabrice Popineau
2012-03-24 18:42 ` Eli Zaretskii
2011-11-12 17:10 ` Christoph Scholtes
2011-11-12 20:37 ` Eli Zaretskii
2011-11-05 23:44 ` Fabrice Popineau
2011-11-06 3:42 ` Christoph Scholtes
2011-11-06 4:02 ` Eli Zaretskii
2011-11-08 6:43 ` bug#9960: fix for Bug#9772 should also help fix Bug#9960 Paul Eggert
2011-11-28 9:34 ` bug#9960: "emacsclient.c (main) <environ>: Remove declaration, " breaks build on Mac OS X David Caldwell
2011-11-28 17:29 ` bug#9960: : " Leon Zhang
2011-11-30 15:48 ` bug#9960: Compiling Emacs trunk with MSVC Tim Crews
2011-11-30 16:30 ` Tim Crews
2011-11-30 18:04 ` Eli Zaretskii
2011-11-30 18:22 ` Tim Crews
2011-11-30 19:17 ` Eli Zaretskii
2011-11-30 19:42 ` Tim Crews [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED68710.5020304@code-affinity.com \
--to=tim.crews@code-affinity.com \
--cc=9960@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).