From: Eli Zaretskii <eliz@gnu.org>
To: Christoph Scholtes <cschol2112@googlemail.com>
Cc: fabrice.popineau@supelec.fr, 9960@debbugs.gnu.org
Subject: bug#9960: Compiling Emacs trunk with MSVC
Date: Sat, 05 Nov 2011 16:16:40 +0200 [thread overview]
Message-ID: <83r51mk62f.fsf@gnu.org> (raw)
In-Reply-To: <4EB540F4.7080106@gmail.com>
> Date: Sat, 05 Nov 2011 07:58:12 -0600
> From: Christoph Scholtes <cschol2112@googlemail.com>
> CC: fabrice.popineau@supelec.fr, 9960@debbugs.gnu.org
>
> On 11/5/2011 7:22 AM, Eli Zaretskii wrote:
>
> > Does this patch give good results?
>
> Yes. Better. Thanks.
Committed.
> Then it can't find a definition of `mode_t' in `strmode'.
>
> This patch will fix this error:
>
> /* Define to the equivalent of the C99 'restrict' keyword, or to
> nothing if this is not supported. Do not define if restrict is
> @@ -341,6 +345,13 @@
> # define restrict
> #endif
>
> +/* Define to `int' if <sys/types.h> does not define. */
> +#ifdef __GNUC__
> +/* No action required for gcc */
> +#else /* MSVC */
> +#define mode_t int
> +#endif
> +
> /* A va_copy replacement for MSVC. */
> #ifdef _MSC_VER
> # ifdef _WIN64
Please commit this, thanks.
> After that, I get a link error for ctags:
>
> ctags.obj : error LNK2019: unresolved external symbol _sys_stat
> referenced in fu
> nction _process_file_name
> obj/i386/ctags.exe : fatal error LNK1120: 1 unresolved externals
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
> Studio 9.0\
> VC\BIN\link.EXE"' : return code '0x460'
> Stop.
> NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual
> Studio 9.0\
> VC\BIN\nmake.exe"' : return code '0x2'
> Stop.
>
> I am not sure what to do about _sys_stat.
Try this one:
=== modified file 'src/s/ms-w32.h'
--- src/s/ms-w32.h 2011-11-05 11:34:56 +0000
+++ src/s/ms-w32.h 2011-11-05 14:15:45 +0000
@@ -191,6 +191,11 @@ struct sigaction {
#include <sys/timeb.h>
#include <sys/stat.h>
#include <signal.h>
+
+/* MSVC gets link-time errors without these redirections. */
+#define fstat(a, b) sys_fstat(a, b)
+#define stat(a, b) sys_stat(a, b)
+#define utime sys_utime
#endif
/* Calls that are emulated or shadowed. */
@@ -279,18 +284,10 @@ typedef int pid_t;
#if !defined (_MSC_VER) || (_MSC_VER < 1400)
#define tzname _tzname
+#undef utime
#define utime _utime
#endif
-#ifdef _MSC_VER
-/* MSVC gets link-time errors without these redirections. */
-#define fstat(a, b) sys_fstat(a, b)
-#define stat(a, b) sys_stat(a, b)
-#if _MSC_VER >= 1400
-#define utime sys_utime
-#endif
-#endif
-
/* This is hacky, but is necessary to avoid warnings about macro
redefinitions using the SDK compilers. */
#ifndef __STDC__
next prev parent reply other threads:[~2011-11-05 14:16 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <loom.20101206T214649-301@post.gmane.org>
[not found] ` <83sjy5279e.fsf@gnu.org>
[not found] ` <AANLkTikmhiNmd5gz8wkpqbgHni2LKkjhTtnPizaOEz7T@mail.gmail.com>
2011-11-05 11:19 ` bug#9960: Compiling Emacs trunk with MSVC Eli Zaretskii
2011-11-05 11:39 ` Eli Zaretskii
2011-11-05 12:54 ` Christoph Scholtes
2011-11-05 13:22 ` Eli Zaretskii
2011-11-05 13:58 ` Christoph Scholtes
2011-11-05 14:16 ` Eli Zaretskii [this message]
2011-11-05 14:53 ` Eli Zaretskii
2011-11-05 15:51 ` Óscar Fuentes
2011-11-05 16:10 ` Eli Zaretskii
2011-11-05 16:27 ` Christoph Scholtes
2011-11-05 16:50 ` Eli Zaretskii
2011-11-05 16:57 ` Eli Zaretskii
2011-11-05 17:22 ` Christoph Scholtes
2011-11-05 18:20 ` Christoph Scholtes
2011-11-05 19:33 ` Eli Zaretskii
2011-11-05 20:38 ` Christoph Scholtes
2011-11-05 21:11 ` Eli Zaretskii
2011-11-05 22:07 ` Christoph Scholtes
2011-11-05 22:15 ` Christoph Scholtes
2011-11-05 22:22 ` Christoph Scholtes
2011-11-06 4:03 ` Eli Zaretskii
2011-11-05 20:32 ` Christoph Scholtes
2011-11-05 21:27 ` Eli Zaretskii
2011-11-05 22:23 ` Christoph Scholtes
2011-11-06 1:50 ` Christoph Scholtes
2011-11-06 5:47 ` Eli Zaretskii
2011-11-06 5:37 ` Eli Zaretskii
2011-11-07 16:13 ` Fabrice Popineau
2011-11-07 16:57 ` Eli Zaretskii
[not found] ` <CAFgFV9N4w+wi4J84BhoEZrgAuwJdFZtWzOAkdb_T9+B7L+Ftfg@mail.gmail.com>
2011-11-08 16:51 ` Eli Zaretskii
2011-11-07 17:03 ` Eli Zaretskii
2011-11-10 19:56 ` Fabrice Popineau
2011-11-10 20:28 ` Lennart Borgman
2011-11-10 20:31 ` Juanma Barranquero
2011-11-10 20:29 ` Juanma Barranquero
2011-11-20 20:59 ` Fabrice Popineau
2011-11-20 21:15 ` Juanma Barranquero
2011-11-20 21:35 ` Dan Nicolaescu
2011-11-20 21:40 ` Juanma Barranquero
2011-11-21 2:30 ` Stefan Monnier
2011-11-21 2:45 ` Juanma Barranquero
2011-11-21 3:51 ` Eli Zaretskii
2011-11-21 8:21 ` Andreas Schwab
2011-11-21 9:54 ` Eli Zaretskii
2011-11-21 12:14 ` Juanma Barranquero
2011-11-21 13:56 ` Eli Zaretskii
2011-12-04 8:06 ` Fabrice Popineau
2011-12-05 5:11 ` Eli Zaretskii
2011-11-21 15:55 ` Richard Stallman
2011-11-11 9:39 ` Eli Zaretskii
2011-11-11 19:28 ` Fabrice Popineau
2011-11-11 19:53 ` Eli Zaretskii
2011-11-11 21:55 ` Fabrice Popineau
2011-11-12 13:50 ` Eli Zaretskii
2011-11-12 14:34 ` Fabrice Popineau
2011-11-12 15:59 ` Óscar Fuentes
2011-11-12 23:32 ` Richard Stallman
2011-11-12 14:27 ` Eli Zaretskii
2011-11-12 17:55 ` Fabrice Popineau
2011-11-12 20:48 ` Eli Zaretskii
2011-11-12 22:27 ` Fabrice Popineau
2011-11-12 22:44 ` Fabrice Popineau
2011-11-12 23:08 ` Fabrice Popineau
2011-11-13 14:45 ` Christoph Scholtes
2011-11-27 19:05 ` Eli Zaretskii
2011-11-28 9:18 ` YAMAMOTO Mitsuharu
2011-11-28 11:51 ` Eli Zaretskii
2011-11-28 19:07 ` Fabrice Popineau
2012-03-24 13:46 ` Eli Zaretskii
2012-03-24 16:10 ` Fabrice Popineau
2012-03-24 18:42 ` Eli Zaretskii
2011-11-12 17:10 ` Christoph Scholtes
2011-11-12 20:37 ` Eli Zaretskii
2011-11-05 23:44 ` Fabrice Popineau
2011-11-06 3:42 ` Christoph Scholtes
2011-11-06 4:02 ` Eli Zaretskii
2011-11-08 6:43 ` bug#9960: fix for Bug#9772 should also help fix Bug#9960 Paul Eggert
2011-11-28 9:34 ` bug#9960: "emacsclient.c (main) <environ>: Remove declaration, " breaks build on Mac OS X David Caldwell
2011-11-28 17:29 ` bug#9960: : " Leon Zhang
2011-11-30 15:48 ` bug#9960: Compiling Emacs trunk with MSVC Tim Crews
2011-11-30 16:30 ` Tim Crews
2011-11-30 18:04 ` Eli Zaretskii
2011-11-30 18:22 ` Tim Crews
2011-11-30 19:17 ` Eli Zaretskii
2011-11-30 19:42 ` Tim Crews
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83r51mk62f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=9960@debbugs.gnu.org \
--cc=cschol2112@googlemail.com \
--cc=fabrice.popineau@supelec.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).