From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tim Crews Newsgroups: gmane.emacs.bugs Subject: bug#9960: Compiling Emacs trunk with MSVC Date: Wed, 30 Nov 2011 12:42:08 -0700 Message-ID: <4ED68710.5020304@code-affinity.com> References: <8339e2lsu7.fsf@gnu.org> <4ED65062.8070607@code-affinity.com> <8339d55vx8.fsf@gnu.org> <4ED6744D.70508@code-affinity.com> <83y5ux4dya.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1322682193 21764 80.91.229.12 (30 Nov 2011 19:43:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2011 19:43:13 +0000 (UTC) Cc: 9960@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 20:43:08 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RVq3f-0001Qs-Vr for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 20:43:08 +0100 Original-Received: from localhost ([::1]:50113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVq3f-00081V-IW for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 14:43:07 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:60320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVq3Z-00081F-Re for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 14:43:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVq3V-0001Uy-Iv for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 14:43:01 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVq3V-0001Uu-HN for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 14:42:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RVq3a-0008LC-1T for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 14:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tim Crews Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2011 19:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9960 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by 9960-submit@debbugs.gnu.org id=B9960.132268214532002 (code B ref 9960); Wed, 30 Nov 2011 19:43:01 +0000 Original-Received: (at 9960) by debbugs.gnu.org; 30 Nov 2011 19:42:25 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVq2y-0008K6-91 for submit@debbugs.gnu.org; Wed, 30 Nov 2011 14:42:25 -0500 Original-Received: from caiajhbdcaib.dreamhost.com ([208.97.132.81] helo=homiemail-a74.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVq2u-0008Jr-3c for 9960@debbugs.gnu.org; Wed, 30 Nov 2011 14:42:21 -0500 Original-Received: from homiemail-a74.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a74.g.dreamhost.com (Postfix) with ESMTP id 0C77E67C07E; Wed, 30 Nov 2011 11:42:14 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=code-affinity.com; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s= code-affinity.com; b=B8APWn7kHvyUhjL0hjzsyUljhr5GgiXkgNKlMeIg2hr m7rlCTYPj9Dcvl/Gb3VVUCN48yN1xQsVhetLtdf20fsPy3bEIOx2pFNLIVeykoAo /30pNJTjrOMuh5hLena0csY3smpR6o5+EhOLhbreZt6IopvXk6WAFbd7lzejJkiM = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=code-affinity.com; h= message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; s= code-affinity.com; bh=TdDZQ6Eq22BAxkM1VklNAaJ1T8M=; b=iXfeCmJTvw 0ktCUjf+LPHxScHsBcnFT/XmLq/+GbZWzWS9ELb8XwBKu18YJ5/UN5yikPvTiwpX wUTKBeexyzFzbAWaqLIuAuDHwq83L02wsQYVdPL81n4+rfPgZ6BZxEbkbxX44BgY oZvi2ZoHDzwcCiRLnW0fl0AggVZmkICYk= Original-Received: from [192.168.1.100] (ip24-251-175-208.ph.ph.cox.net [24.251.175.208]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tim.crews@code-affinity.com) by homiemail-a74.g.dreamhost.com (Postfix) with ESMTPSA id AECE967C07D; Wed, 30 Nov 2011 11:42:11 -0800 (PST) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 In-Reply-To: <83y5ux4dya.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 30 Nov 2011 14:43:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54515 Archived-At: On 11/30/2011 12:17 PM, Eli Zaretskii wrote: >> Date: Wed, 30 Nov 2011 11:22:05 -0700 >> From: Tim Crews >> Cc: 9960@debbugs.gnu.org >> >>> If you tried a 64-bit build, then it is not yet supported on Windows. >>> Try the 32-bit build, it should work. >> >> I was doing a 32-bit build. There are still a few minor changes from >> Fabrice Popineau that haven't made it into bzr yet. >> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9960#224) With those >> changes, the build succeeds. > > Which changes, specifically, are needed? I know only about one issue: > the one with _tzname. The rest, to the best of my knowledge, are for > a 64-bit build. If I'm wrong, I'd like to know which other changes > are still needed for the 32-bit build with MSVC. > >> I built from the latest bzr source and can confirm that the linum-mode >> crash no longer occurs on my end. > > Thanks. There are only two changes listed in but 9960 message 224, both related to _tzname. (The patch is repeated for reference at the bottom of this message.) The changes are to lib/strftime.c and src/s/ms-w32.h. If I back out Fabrice's proposed change to lib/strftime.c, the build succeeds through the compilation phase but fails to link because of unresolved external _tzname. If I back out Fabrice's proposed change to src/s/ms-w32.h, compilation of ntlib.c fails with "time.h(270) : error C2090: function returns array". So it appears that both changes are needed for the MSVC 32-bit build. Tim Crews === modified file 'lib/strftime.c' --- lib/strftime.c 2011-03-31 04:24:03 +0000 +++ lib/strftime.c 2011-11-28 15:38:55 +0000 @@ -36,9 +36,13 @@ #include #include +#ifdef _MSC_VER +#define tzname _tzname +#else #if HAVE_TZNAME && !HAVE_DECL_TZNAME extern char *tzname[]; #endif +#endif /* Do multibyte processing if multibytes are supported, unless multibyte sequences are safe in formats. Multibyte sequences are === modified file 'src/s/ms-w32.h' --- src/s/ms-w32.h 2011-11-27 18:52:53 +0000 +++ src/s/ms-w32.h 2011-11-28 15:33:33 +0000 @@ -286,7 +286,9 @@ #define stricmp _stricmp #define tzset _tzset +#ifndef _MSC_VER #define tzname _tzname +#endif #if !defined (_MSC_VER) || (_MSC_VER < 1400) #undef utime #define utime _utime