From: "Nicholas Savage" <nick@nicksavage.ca>
To: 39912@debbugs.gnu.org
Subject: bug#39912: [PATCH] Open describe-function links in view-mode (Bug#39912)
Date: Tue, 08 Sep 2020 16:27:56 -0400 [thread overview]
Message-ID: <48e2dded-3082-4ed0-96dd-784bb5623782@www.fastmail.com> (raw)
In-Reply-To: <87v9nkm137.fsf@betli.tmit.bme.hu>
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
Hello,
I've written a patch for Bug #39912, as discussed in debbugs. I think I have formatted this correctly and have followed CONTRIBUTE as best as I could.
I've marked the patch as exempt from copyright assignment as my understanding is that 15 lines of code is the threshold. That being said, I have no problems assigning copyright for this and for future patches, and I would like to get the ball rolling on that now if possible.
One thing I should mention is that the thread discussed view-mode for NEWS links in describe-function. I've also changed it so the actual source code link opens in view-mode as well. I don't know if there are ramifications of that, so I'm happy to change it if necessary. My thought process was that describe-function is used as a reference to the code, not as a point of entry for editing functions, so changing that is consistent with changing the NEWS links, but I don't know what I don't know.
Thanks,
Nick
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Open-describe-function-links-in-view-mode-Bug-39912.patch --]
[-- Type: text/x-patch; name="0001-Open-describe-function-links-in-view-mode-Bug-39912.patch", Size: 1259 bytes --]
From 61bceceb2155d4521625f947be889743c8d3c27b Mon Sep 17 00:00:00 2001
From: Nick Savage <nick@nicksavage.ca>
Date: Tue, 8 Sep 2020 16:08:30 -0400
Subject: [PATCH] Open describe-function links in view-mode (Bug#39912)
* Open describe-function links in view-mode (Bug#39912) to make
behavior consistent depending on whether or not user has permission
to edit the files.
Copyright-paperwork-exempt: yes
---
lisp/help-mode.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index 9c2d1d7227..673e7bf304 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -204,7 +204,7 @@ help-function-def--button-function
(let* ((location
(find-function-search-for-symbol fun type file))
(position (cdr location)))
- (pop-to-buffer (car location))
+ (view-buffer (car location))
(run-hooks 'find-function-after-hook)
(if position
(progn
@@ -308,7 +308,7 @@ 'help-news
:supertype 'help-xref
'help-function
(lambda (file pos)
- (pop-to-buffer (find-file-noselect file))
+ (view-buffer (find-file-noselect file))
(goto-char pos))
'help-echo (purecopy "mouse-2, RET: show corresponding NEWS announcement"))
\f
--
2.20.1
next prev parent reply other threads:[~2020-09-08 20:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 18:22 bug#39912: 27.0.90; Probably introduced at or before Emacs version Felician Nemeth
2020-09-07 19:54 ` bug#39912: "Probably introduced at or before Emacs version ..." link should open NEWS read-only Nicholas Savage
2020-09-07 21:00 ` Lars Ingebrigtsen
2020-09-08 6:59 ` Andreas Schwab
2020-09-08 7:25 ` Stefan Kangas
2020-09-08 7:26 ` Andreas Schwab
2020-09-08 10:26 ` Lars Ingebrigtsen
[not found] ` <871rjdi0wb.fsf@nicksavage.ca>
[not found] ` <87v9go4kzq.fsf@gnus.org>
2020-09-08 11:26 ` Nicholas Savage
2020-09-08 13:54 ` Stefan Kangas
2020-09-08 20:27 ` Nicholas Savage [this message]
2020-09-08 21:01 ` bug#39912: [PATCH] Open describe-function links in view-mode (Bug#39912) Stefan Kangas
2020-09-08 21:04 ` Lars Ingebrigtsen
2020-09-09 0:14 ` Nicholas Savage
2020-09-09 9:39 ` Lars Ingebrigtsen
2020-09-10 0:43 ` Nicholas Savage
2020-09-10 13:19 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e2dded-3082-4ed0-96dd-784bb5623782@www.fastmail.com \
--to=nick@nicksavage.ca \
--cc=39912@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).