bug#39912: [PATCH] Open describe-function links in view-mode (Bug#39912)

["Nicholas Savage" <nick@nicksavage.ca>]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

Good call. I've changed it to using view-buffer-other-window instead, which I think gets us where we want to be - it opens the NEWS file in view-mode, but also in another window as is consistent with previous behaviour.

On Wed, Sep 9, 2020, at 05:39, Lars Ingebrigtsen wrote:
> "Nicholas Savage" <nick@nicksavage.ca> writes:
> 
> > -    (pop-to-buffer (find-file-noselect file))
> > +    (view-buffer (find-file-noselect file))
> 
> pop-to-buffer opens the NEWS buffer in a different window, though, while
> view-buffer stays in the same window.  So perhaps it should pop first
> and then call view-buffer?
> 
> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Open-describe-function-NEWS-links-in-view-mode-Bug-3.patch --]
[-- Type: text/x-patch; name="0001-Open-describe-function-NEWS-links-in-view-mode-Bug-3.patch", Size: 879 bytes --]

From b634e095982ff45bfb43363ae8fadaea20885800 Mon Sep 17 00:00:00 2001
From: Nick Savage <nick@nicksavage.ca>
Date: Tue, 8 Sep 2020 16:08:30 -0400
Subject: [PATCH] Open describe-function NEWS links in view-mode (Bug#39912)

* lisp/help-mode.el (help-news): Open describe-function NEWS links in
view-mode (Bug#39912)

Copyright-paperwork-exempt: yes
---
 lisp/help-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index 9c2d1d7227..0dc6c9ffae 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -308,7 +308,7 @@ 'help-news
   :supertype 'help-xref
   'help-function
   (lambda (file pos)
-    (pop-to-buffer (find-file-noselect file))
+    (view-buffer-other-window (find-file-noselect file))
     (goto-char pos))
   'help-echo (purecopy "mouse-2, RET: show corresponding NEWS announcement"))
 \f
-- 
2.20.1