unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 47799@debbugs.gnu.org
Subject: bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames
Date: Thu, 22 Apr 2021 03:46:17 +0300	[thread overview]
Message-ID: <40e4cb97-c0e5-9ec1-123d-0f73a39e34c2@yandex.ru> (raw)
In-Reply-To: <91dd2467-f64e-eede-8098-14fc8ccd7ae7@yandex.ru>

On 19.04.2021 23:48, Dmitry Gutov wrote:
> And how will we explain anyway that xref-matches-in-files, when called 
> without the new ROOT argument, doesn't handle remote or quoted file names?

The above is probably the only real blocker I see. Else we would need to 
document it to explicitly only take relative file names, I think. Do we 
have a precedent in the core library for this?

Other than that, an exploration into an API working with relative files 
names sounds good, actually. It could further speed up file listing, 
eliminating some concatenations in project--vc-list-files (in the big 
project I referred to, that takes it from 1s down to 0.75s).

If you have the time, patches welcome, even rough ones.

> So if you can fix this to avoid performance loss in the general case, 
> that would be a good improvement for now.

In the meantime, I've changed the fix to use the plan explained previously.

Downsides: either all files should be quoted, or none (is that a 
reasonable assumption?), and, of course, users which which do have 
directories making use of quoting still pay the performance overhead.





  reply	other threads:[~2021-04-22  0:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 13:43 bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames Philipp Stephani
2021-04-15 16:15 ` Dmitry Gutov
2021-04-15 16:26   ` Philipp Stephani
2021-04-15 16:44   ` Philipp Stephani
2021-04-16  1:08     ` Dmitry Gutov
2021-04-18 20:06       ` Philipp Stephani
2021-04-18 20:21         ` Dmitry Gutov
2021-04-19 14:48           ` Philipp Stephani
2021-04-19 20:48             ` Dmitry Gutov
2021-04-22  0:46               ` Dmitry Gutov [this message]
2021-05-16 13:37               ` Philipp
2021-05-16 23:22                 ` Dmitry Gutov
2021-05-16 23:31                   ` Dmitry Gutov
2021-07-05 19:05                   ` Philipp
2021-07-18  0:53                     ` Dmitry Gutov
2021-09-05 17:14                       ` Philipp
2021-09-20 16:05                         ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40e4cb97-c0e5-9ec1-123d-0f73a39e34c2@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=47799@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).