From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames Date: Thu, 22 Apr 2021 03:46:17 +0300 Message-ID: <40e4cb97-c0e5-9ec1-123d-0f73a39e34c2@yandex.ru> References: <658a3e61-9511-5502-43de-8f591cec7387@yandex.ru> <91dd2467-f64e-eede-8098-14fc8ccd7ae7@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34911"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: 47799@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 22 02:47:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZNUz-0008xO-CL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Apr 2021 02:47:17 +0200 Original-Received: from localhost ([::1]:55878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZNUx-00046o-Rv for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 20:47:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZNUk-00046i-Lj for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 20:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZNUk-0003zi-DZ for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 20:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZNUk-00060a-Ay for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 20:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Apr 2021 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47799 X-GNU-PR-Package: emacs Original-Received: via spool by 47799-submit@debbugs.gnu.org id=B47799.161905238923051 (code B ref 47799); Thu, 22 Apr 2021 00:47:02 +0000 Original-Received: (at 47799) by debbugs.gnu.org; 22 Apr 2021 00:46:29 +0000 Original-Received: from localhost ([127.0.0.1]:60119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZNUD-0005zj-2f for submit@debbugs.gnu.org; Wed, 21 Apr 2021 20:46:29 -0400 Original-Received: from mail-ej1-f51.google.com ([209.85.218.51]:41600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZNUB-0005zT-4Y for 47799@debbugs.gnu.org; Wed, 21 Apr 2021 20:46:28 -0400 Original-Received: by mail-ej1-f51.google.com with SMTP id mh2so44565543ejb.8 for <47799@debbugs.gnu.org>; Wed, 21 Apr 2021 17:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aZrxETZhy2QkPq5d3aM/ToTN0U1Xn4cN/va8nqffDTs=; b=HDy8S1w/M6UZ8bwkDHH4SKFupZsmHTFSUpxgX+py0OBkge/jB43HLtwNK0CuR0cjjh U/q1W4O1klfZOW1wFbOY/kA/rabHbagiWzISI8Z+tsXk1ONPK/KQnTb6Xmx7dcMNdiOV TTQ+L2Ugybx6RADMKD+grL4gYzvxkdJRJdReDSEGlbL/X+7D7PrVevdHwpFsjztuqwQX vPTcY5ChWQfWOwuNzGQeoKy/BujzAovask5OliV/JJul/8Q8CAWkuywwAR9FnhaCkNjk RdkvSioXA6iOcoPxPdcamIsTwt2qy+tDVMKy3ChvQThpy+UmuXtUjkFqQV1z9W221uQj +IMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aZrxETZhy2QkPq5d3aM/ToTN0U1Xn4cN/va8nqffDTs=; b=ZiWIG1ifNzMJZPPAz7TgW0pldzP0fJbGlx8+uTmMbtshdrc7lC+IfacRV6dIYlMWOM swlENPaw6sSEGdSUWqok3dM4rTMWjwunP3s1LujDKkUbSzyDvK2IJar5vMWD8MN/GK9B d2zAY//zdLwlQ/a3AWzf34dda5XeyFDqY2b8ou8mwfhzqqCVAi70xutr0kvl6ySvmXUI mtQAHxEaIAj6NyBZnRI0Ksuhf4CXwPqRcNdS8ikPX3OmTcMToJelX5BO9+FIMJtvaz5F pe09ZIRHNZDb5CUK5OVGqlnZlCFKgHORtnElkpF4Qr52yp5/uO/jAuehzIeX1QGfaYH0 zuFg== X-Gm-Message-State: AOAM532LBBwlGfxM4RomMyrOseoswQQooxJueFvI69HULdCQZEMPKqD9 NbHxJSSkihJsqZldPtoFW4paci68cLU= X-Google-Smtp-Source: ABdhPJxdlQZLKlwKibkt0Bem4kFO2xcEnIEECuqHjUtfM1ILWOIVDdBWcNbZU4Il2edS6qJ42DZVQQ== X-Received: by 2002:a17:906:dc90:: with SMTP id cs16mr563369ejc.210.1619052381223; Wed, 21 Apr 2021 17:46:21 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f19sm729099ejc.54.2021.04.21.17.46.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 17:46:19 -0700 (PDT) In-Reply-To: <91dd2467-f64e-eede-8098-14fc8ccd7ae7@yandex.ru> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204672 Archived-At: On 19.04.2021 23:48, Dmitry Gutov wrote: > And how will we explain anyway that xref-matches-in-files, when called > without the new ROOT argument, doesn't handle remote or quoted file names? The above is probably the only real blocker I see. Else we would need to document it to explicitly only take relative file names, I think. Do we have a precedent in the core library for this? Other than that, an exploration into an API working with relative files names sounds good, actually. It could further speed up file listing, eliminating some concatenations in project--vc-list-files (in the big project I referred to, that takes it from 1s down to 0.75s). If you have the time, patches welcome, even rough ones. > So if you can fix this to avoid performance loss in the general case, > that would be a good improvement for now. In the meantime, I've changed the fix to use the plan explained previously. Downsides: either all files should be quoted, or none (is that a reasonable assumption?), and, of course, users which which do have directories making use of quoting still pay the performance overhead.