From: Philipp Stephani <p.stephani2@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 47799@debbugs.gnu.org
Subject: bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames
Date: Thu, 15 Apr 2021 18:26:21 +0200 [thread overview]
Message-ID: <CAArVCkSD5Jr1n4TTq5J7rZSU46=RFzxE2JcpR6tgru8JuKdpAg@mail.gmail.com> (raw)
In-Reply-To: <658a3e61-9511-5502-43de-8f591cec7387@yandex.ru>
Am Do., 15. Apr. 2021 um 18:15 Uhr schrieb Dmitry Gutov <dgutov@yandex.ru>:
>
> Hi Philipp,
>
> On 15.04.2021 16:43, Philipp Stephani wrote:
> > emacs -Q -batch -l project -eval '(print (project-files (quote (transient . "/:/"))))'
> >
> > ("find: ‘/:/’: No such file or directory
> > ")
> >
> > Note that the error message is listed as a file.
> >
> > 1. `project-files' should unquote local filenames before passing them to
> > `find'.
> >
> > 2. `project-files' should check for errors returned from `find'.
>
> Would you like to propose a patch?
>
> I don't really understand the file quoting feature.
>
> Is project--files-in-directory supposed to unquote? Should
> project--vc-list-files do that as well?
I think only functions that pass filenames to external programs (that
don't know about Emacs filename handlers) should unquote. Unquoting
can change the meaning of a filename.
From what I can see, project--vs-list-files shouldn't unquote, because
it doesn't pass filenames to external programs.
>
> Does read-directory-name return quoted names when needed? Can
> locate-dominating-file return one?
Yes, both of these can return quoted names.
next prev parent reply other threads:[~2021-04-15 16:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 13:43 bug#47799: 28.0.50; Default `project-files' implementation doesn't work with quoted filenames Philipp Stephani
2021-04-15 16:15 ` Dmitry Gutov
2021-04-15 16:26 ` Philipp Stephani [this message]
2021-04-15 16:44 ` Philipp Stephani
2021-04-16 1:08 ` Dmitry Gutov
2021-04-18 20:06 ` Philipp Stephani
2021-04-18 20:21 ` Dmitry Gutov
2021-04-19 14:48 ` Philipp Stephani
2021-04-19 20:48 ` Dmitry Gutov
2021-04-22 0:46 ` Dmitry Gutov
2021-05-16 13:37 ` Philipp
2021-05-16 23:22 ` Dmitry Gutov
2021-05-16 23:31 ` Dmitry Gutov
2021-07-05 19:05 ` Philipp
2021-07-18 0:53 ` Dmitry Gutov
2021-09-05 17:14 ` Philipp
2021-09-20 16:05 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkSD5Jr1n4TTq5J7rZSU46=RFzxE2JcpR6tgru8JuKdpAg@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=47799@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).