From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#31772: 26.1; (thing-at-point 'list) regression Date: Thu, 6 Sep 2018 21:01:55 +0200 Message-ID: <27715d72-6339-f1ca-23e5-4426d822b84c@easy-emacs.de> References: <838t7msmy1.fsf@gnu.org> <87k1r6acqo.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1536260171 24807 195.159.176.226 (6 Sep 2018 18:56:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Sep 2018 18:56:11 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: 31772@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 06 20:56:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxzRm-0006LG-Kh for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Sep 2018 20:56:06 +0200 Original-Received: from localhost ([::1]:35063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxzTt-00028W-2F for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Sep 2018 14:58:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxzTi-00027P-8K for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:58:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxzTe-0006AT-SJ for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:58:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43364) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxzTe-00069w-LC for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fxzTe-0005qt-H2 for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Sep 2018 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.153626027922484 (code B ref -1); Thu, 06 Sep 2018 18:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Sep 2018 18:57:59 +0000 Original-Received: from localhost ([127.0.0.1]:48382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxzTb-0005qZ-CW for submit@debbugs.gnu.org; Thu, 06 Sep 2018 14:57:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxzTZ-0005qL-LE for submit@debbugs.gnu.org; Thu, 06 Sep 2018 14:57:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxzTT-0005nn-Ha for submit@debbugs.gnu.org; Thu, 06 Sep 2018 14:57:52 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54433) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fxzTT-0005nF-Cp for submit@debbugs.gnu.org; Thu, 06 Sep 2018 14:57:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxzTS-00023j-HC for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:57:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxzTP-0005i6-8F for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:57:50 -0400 Original-Received: from mout.kundenserver.de ([212.227.126.133]:57167) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxzTO-0005eq-Tp for bug-gnu-emacs@gnu.org; Thu, 06 Sep 2018 14:57:47 -0400 Original-Received: from [192.168.178.35] ([188.102.48.98]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.167]) with ESMTPSA (Nemesis) id 0Mgrp6-1gB6Vr3xlQ-00M3zC; Thu, 06 Sep 2018 20:57:44 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:xlAB+trz1+hgz52qb3nDvsw/5Yx+dMJ1Fj9VKtT1UW0Ncxm2aqx t812eSKOgjjeickisMouVJYUWn9MdPPrmYsJz3i64NJi47z52woWU7EVQHnUSDG3SK0CSFE nTI7BTl/4D70RteIttkjWT2yAg4DjOnn5IUfYk22WLMQqPfHFTyI2NnfcPmYREGvFG6tdAg Tiv9HaB/NhM7s4bnewuVQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:rcg+X95Sfh0=:rJ5oF6KL8AZ9XN0oQAa2jw i4Ia0TrQoiqNOQ1jPa/xbnjMiuI/FW8y4zFQZ5/O7yYmlstIgwJx/xafeGGxfeblnvysYM9g6 cc42BhgP/6mtEtGrngmSCr5o/XQqS7dy27hOO9Ofj6ITkRxU8QcAwGCgCffTGSbM6h3jWmbqu b1njOHxeaYVXsdA342fEjvTL54rlGCvsHp2qkbQBU24ZtAUekukjM3oK5BthEDwpAr0R6BmjB YuWflSZYKCjVZdP9tBnFYwMwwTPM6qrNNWwP7EhMEAtrMMtfTKCm8LKqLW5VM567LmSyK6+lM QWX0idHNsBneJRFguKqEsLpcJSXMU8pcyvFUhBVtIoT0NfU9hPIcXpswC+/3O7/JD5yU9LBlf IbtQUST2GcPvlpMdHJIkhf5+g1J7BDvurvd2sJVPA7xuOK49GDJg6Ut/Wv3atACnL2X4asNwG GA3b6ykxEpBw3/GdOo3VBBsu634EK0fvNLEbjJxuJmVdkWVwwv1Zrddc2t8KMQWaVmeje8JEe b4fbMz31mNqwSsDQiCv/yENDFDIHxVXyiQ2y76/NuY96dWeYk+6nHYpcHOJ+RcTWuy6iFH6+D i7kiZrPb8WkEbk1VAtQ6QNOm4pTS2usCL+M1eAef/4m1nhabQlFsz/OCXNlW/2GxImIUuhbXy 5t+9xtJCl1OHdlzjUYVB19F7iHkSgYvM8aIA7LGEaQgtNmtoN98iRHE7uJfWhGkVSX2NB0Dwp rXqDcyKneGtdk2qL X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150089 Archived-At: On 06.09.2018 12:37, Leo Liu wrote: > Hi there, > > I have been using 26.1 as my main editor for the last few months and > this breakage remains a pain point in my day-to-day editing. For example > whenever I rewrite a function, I normally comment out the old one (to > keep the linter, pretty-printer or whatnot happy) and write the new one > from scratch, occasionally copy things from the old one to save typing > and this bug gets in the way many times a day. I propose a patch that > doesn't divert too much from the old and tried behaviour. > > The idea that is currently in thing-at-point-bounds-of-list-at-point is > fine for a higher level function such as list-at-point but doing it > there affects all functions that build on it including some from > thingatpt.el itself. > > I hope you can find time to review the patch and come to a solution for > 26.2 which I very much look forward to. > > Thanks, > Leo > Hi Leo, lets consider the following proposed change of tests: - ("(foo\n(a ;(b c d)\ne) bar)" . (a e)) + ("(foo\n(a ;(b c d)\ne) bar)" . (foo (a e) bar)) As the ert-test mentioned calls (re-search-backward "\\((a\\|^a\\)") point will be behind foo at "(a". I.e. "foo" belongs to outer list, not to list-at-point. The desired result shown by this change looks wrong, "(foo" should not be part of. Maybe I'm missing something. May you provide a standalone example where current behavior breaks your code? Thanks, Andreas gladly using GNU Emacs 27.0.50 (build 1, i686-pc-linux-gnu, GTK+ Version 3.14.5) of 2018-08-29