From: Yuuki Harano <masm+emacs@masm11.me>
To: contovob@tcd.ie
Cc: 46493@debbugs.gnu.org
Subject: bug#46493: [feature/pgtk] Low contrast region face
Date: Sun, 14 Feb 2021 12:59:55 +0900 (JST) [thread overview]
Message-ID: <20210214.125955.33145462292773166.masm@luna.pink.masm11.me> (raw)
In-Reply-To: <87sg5zrjos.fsf@tcd.ie>
On Sat, 13 Feb 2021 16:55:47 +0000,
"Basil L. Contovounesios" <contovob@tcd.ie> wrote:
> I understand that each toolkit has its look & feel, and that colour
> perception is subjective, but the default contrast on pgtk strikes me as
> a bit too low for text editing.
lisp/faces.el:
(defface region
'((((class color) (min-colors 88) (background dark))
:background "blue3" :extend t)
(((class color) (min-colors 88) (background light) (type gtk))
:distant-foreground "gtk_selection_fg_color"
:background "gtk_selection_bg_color" :extend t)
The color name "gtk_selection_bg_color" is handled by src/gtkutil.c:
xg_check_special_colors(), which gets colors from gtk theme.
This issue is not pgtk-specific.
If we want another color for bg on pgtk, we can change this face definition as follows:
(defface region
'((((class color) (min-colors 88) (background dark))
:background "blue3" :extend t)
(((class color) (min-colors 88) (background light) (type pgtk)) ; add this line
:background "lightgoldenrod2" :extend t) ; add this line
(((class color) (min-colors 88) (background light) (type gtk))
:distant-foreground "gtk_selection_fg_color"
:background "gtk_selection_bg_color" :extend t)
--
Yuuki Harano
next prev parent reply other threads:[~2021-02-14 3:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 16:55 bug#46493: [feature/pgtk] Low contrast region face Basil L. Contovounesios
2021-02-13 20:21 ` Dmitry Gutov
2021-02-13 20:53 ` Basil L. Contovounesios
2021-02-13 21:12 ` Dmitry Gutov
2021-02-14 12:48 ` Basil L. Contovounesios
2021-02-14 3:59 ` Yuuki Harano [this message]
2021-02-14 13:00 ` Basil L. Contovounesios
2021-02-15 17:06 ` Yuuki Harano
2021-02-15 19:20 ` Basil L. Contovounesios
2022-06-17 13:41 ` Lars Ingebrigtsen
2022-06-18 1:58 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-18 10:04 ` Lars Ingebrigtsen
2022-06-19 2:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-19 11:11 ` Lars Ingebrigtsen
2022-06-19 11:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-19 12:02 ` Lars Ingebrigtsen
2022-06-19 12:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-19 22:41 ` Lars Ingebrigtsen
2022-06-20 0:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 1:12 ` Lars Ingebrigtsen
2022-06-20 1:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 8:53 ` Lars Ingebrigtsen
2022-07-23 8:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 9:09 ` Lars Ingebrigtsen
2022-07-23 9:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 9:37 ` Lars Ingebrigtsen
2022-06-18 15:43 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210214.125955.33145462292773166.masm@luna.pink.masm11.me \
--to=masm+emacs@masm11.me \
--cc=46493@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).