From: Lars Ingebrigtsen <larsi@gnus.org>
To: Yuuki Harano <masm+emacs@masm11.me>
Cc: contovob@tcd.ie, 46493@debbugs.gnu.org, Po Lu <luangruo@yahoo.com>
Subject: bug#46493: [feature/pgtk] Low contrast region face
Date: Fri, 17 Jun 2022 15:41:02 +0200 [thread overview]
Message-ID: <87a6ab8l1t.fsf@gnus.org> (raw)
In-Reply-To: <20210214.125955.33145462292773166.masm@luna.pink.masm11.me> (Yuuki Harano's message of "Sun, 14 Feb 2021 12:59:55 +0900 (JST)")
Yuuki Harano <masm+emacs@masm11.me> writes:
> This issue is not pgtk-specific.
>
> If we want another color for bg on pgtk, we can change this face definition as follows:
The proposed patch was:
diff --git a/lisp/faces.el b/lisp/faces.el
index d92569e7cd..de1ca095aa 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -2502,7 +2502,9 @@ highlight
(defface region
'((((class color) (min-colors 88) (background dark))
:background "blue3" :extend t)
- (((class color) (min-colors 88) (background light) (type gtk))
+ (((class color) (min-colors 88) (background light) (type pgtk))
+ :background "lightgoldenrod2" :extend t)
+ (((class color) (min-colors 88) (background light) (type gtk))
:distant-foreground "gtk_selection_fg_color"
:background "gtk_selection_bg_color" :extend t)
(((class color) (min-colors 88) (background light) (type ns))
But... The gtk_selection_fg_color colour is different under gtk, but not
pgtk -- that's the problem.
Poking at this, it seems the colours we get out of GTK are:
gtk_selection_bg_color 0.964706 0.960784 0.956863
Which is a very, very light colour, which is apparently calculated
correctly in this branch here:
#ifndef HAVE_PGTK
sprintf (buf, "rgb:%04x/%04x/%04x", r, g, b);
success_p = x_parse_color (f, buf, color) != 0;
#else
sprintf (buf, "#%04x%04x%04x", r, g, b);
success_p = pgtk_parse_color (f, buf, color) != 0;
#endif
But with the non-pgtk branch we get a very dark colour. And when taking
this into account:
/* FIXME: Retrieving the background color is deprecated in
GTK+ 3.16. New versions of GTK+ don't use the concept of a
single background color any more, so we shouldn't query for
it. */
gtk_style_context_get (gsty, state,
GTK_STYLE_PROPERTY_BACKGROUND_COLOR, &c,
NULL);
I think we should just remove all of this code and use the same colours
in (p)GTK Emacsen as in non.
Any other opinions?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-06-17 13:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 16:55 bug#46493: [feature/pgtk] Low contrast region face Basil L. Contovounesios
2021-02-13 20:21 ` Dmitry Gutov
2021-02-13 20:53 ` Basil L. Contovounesios
2021-02-13 21:12 ` Dmitry Gutov
2021-02-14 12:48 ` Basil L. Contovounesios
2021-02-14 3:59 ` Yuuki Harano
2021-02-14 13:00 ` Basil L. Contovounesios
2021-02-15 17:06 ` Yuuki Harano
2021-02-15 19:20 ` Basil L. Contovounesios
2022-06-17 13:41 ` Lars Ingebrigtsen [this message]
2022-06-18 1:58 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-18 10:04 ` Lars Ingebrigtsen
2022-06-19 2:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-19 11:11 ` Lars Ingebrigtsen
2022-06-19 11:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-19 12:02 ` Lars Ingebrigtsen
2022-06-19 12:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-19 22:41 ` Lars Ingebrigtsen
2022-06-20 0:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-20 1:12 ` Lars Ingebrigtsen
2022-06-20 1:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 8:53 ` Lars Ingebrigtsen
2022-07-23 8:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 9:09 ` Lars Ingebrigtsen
2022-07-23 9:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 9:37 ` Lars Ingebrigtsen
2022-06-18 15:43 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6ab8l1t.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=46493@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=luangruo@yahoo.com \
--cc=masm+emacs@masm11.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).