From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuuki Harano Newsgroups: gmane.emacs.bugs Subject: bug#46493: [feature/pgtk] Low contrast region face Date: Sun, 14 Feb 2021 12:59:55 +0900 (JST) Organization: Ingage Inc. Message-ID: <20210214.125955.33145462292773166.masm@luna.pink.masm11.me> References: <87sg5zrjos.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25949"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46493@debbugs.gnu.org To: contovob@tcd.ie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 14 05:01:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lB8ay-0006en-ES for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Feb 2021 05:01:16 +0100 Original-Received: from localhost ([::1]:46086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lB8aw-0004pA-RE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 23:01:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lB8ak-0004oy-N3 for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 23:01:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lB8ak-0007d8-Gc for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 23:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lB8ak-0006oF-FM for bug-gnu-emacs@gnu.org; Sat, 13 Feb 2021 23:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuuki Harano Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Feb 2021 04:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46493 X-GNU-PR-Package: emacs Original-Received: via spool by 46493-submit@debbugs.gnu.org id=B46493.161327520326015 (code B ref 46493); Sun, 14 Feb 2021 04:01:02 +0000 Original-Received: (at 46493) by debbugs.gnu.org; 14 Feb 2021 04:00:03 +0000 Original-Received: from localhost ([127.0.0.1]:35343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB8Zm-0006lK-8s for submit@debbugs.gnu.org; Sat, 13 Feb 2021 23:00:02 -0500 Original-Received: from shiro.masm11.me ([150.95.182.25]:57524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lB8Zj-0006ka-M3 for 46493@debbugs.gnu.org; Sat, 13 Feb 2021 23:00:01 -0500 Original-Received: from luna.pink.masm11.me (KD111239255141.au-net.ne.jp [111.239.255.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shiro.masm11.me (Postfix) with ESMTPSA id 286EFC013D; Sun, 14 Feb 2021 12:59:56 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=masm11.me; s=202002; t=1613275196; bh=NL6HrHct4eiC/lr7n1SrDC5BwrakXgbBmDAKJkCLe9Q=; h=Date:To:Cc:Subject:From:In-Reply-To:References; b=zUOOwbnp7NIM1FVYtK1wUi1U0+EGHrH3Z6eoiyq/knO7MFNhhb31jdVSMhyoh1UgH IKQc90TZrTqWHCvAXtoiY0wW0+vDBSLil6va7B+uLxejk+DmFRX1gZmyCq6cLALAl6 RgcPF7V0yYCgVh0VKfCgV71VQaqVMt2A0vBDonA8= In-Reply-To: <87sg5zrjos.fsf@tcd.ie> X-Mailer: Mew version 6.8 on Emacs 28.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199981 Archived-At: On Sat, 13 Feb 2021 16:55:47 +0000, "Basil L. Contovounesios" wrote: > I understand that each toolkit has its look & feel, and that colour > perception is subjective, but the default contrast on pgtk strikes me as > a bit too low for text editing. lisp/faces.el: (defface region '((((class color) (min-colors 88) (background dark)) :background "blue3" :extend t) (((class color) (min-colors 88) (background light) (type gtk)) :distant-foreground "gtk_selection_fg_color" :background "gtk_selection_bg_color" :extend t) The color name "gtk_selection_bg_color" is handled by src/gtkutil.c: xg_check_special_colors(), which gets colors from gtk theme. This issue is not pgtk-specific. If we want another color for bg on pgtk, we can change this face definition as follows: (defface region '((((class color) (min-colors 88) (background dark)) :background "blue3" :extend t) (((class color) (min-colors 88) (background light) (type pgtk)) ; add this line :background "lightgoldenrod2" :extend t) ; add this line (((class color) (min-colors 88) (background light) (type gtk)) :distant-foreground "gtk_selection_fg_color" :background "gtk_selection_bg_color" :extend t) -- Yuuki Harano