From: Boruch Baum <boruch_baum@gmx.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 43714@debbugs.gnu.org
Subject: bug#43714: 28.1: auto-revert code improvements [PATCH]
Date: Wed, 30 Sep 2020 12:59:34 -0400 [thread overview]
Message-ID: <20200930165857.6sdswdttxiy4gly7@E15-2016.optimum.net> (raw)
In-Reply-To: <83h7rfi74k.fsf@gnu.org>
On 2020-09-30 19:03, Eli Zaretskii wrote:
> Why is that a problem to leave save-match-data alone? Does it do any
> harm?
I explicitly said in the introduction to the patch that it wasn't
'fixing' anything broken, just cleaning things up (potentially /
hopefully). When I was researching how to best implement that "auto-revert
only if visible" feature, I found myself puzzling over some parts of the
code and came to clean it up to be better able to wok on it.
That said, You could leave the (save-match-data alone, and accept the other
changes; the other proposed changes are clearly independent.
--
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
next prev parent reply other threads:[~2020-09-30 16:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 6:26 bug#43714: 28.1: auto-revert code improvements [PATCH] Boruch Baum
2020-09-30 13:48 ` Lars Ingebrigtsen
2020-09-30 14:25 ` Eli Zaretskii
2020-09-30 15:28 ` Boruch Baum
2020-09-30 16:03 ` Eli Zaretskii
2020-09-30 16:59 ` Boruch Baum [this message]
2020-09-30 17:01 ` Lars Ingebrigtsen
2020-09-30 17:13 ` Boruch Baum
2020-09-30 17:21 ` Michael Albinus
2020-09-30 15:09 ` Boruch Baum
2020-09-30 15:12 ` Lars Ingebrigtsen
2020-09-30 17:41 ` Glenn Morris
2020-09-30 18:33 ` Boruch Baum
2020-09-30 23:55 ` Lars Ingebrigtsen
2020-10-01 5:42 ` Boruch Baum
2020-09-30 16:51 ` bug#43714: [boruch_baum@gmx.com: Re: bug#43714: 28.1: auto-revert code improvements [PATCH]] Boruch Baum
2020-09-30 16:54 ` Lars Ingebrigtsen
2020-09-30 17:10 ` Boruch Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930165857.6sdswdttxiy4gly7@E15-2016.optimum.net \
--to=boruch_baum@gmx.com \
--cc=43714@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).