unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
	boruch_baum@gmx.com, 43714@debbugs.gnu.org
Subject: bug#43714: 28.1: auto-revert code improvements [PATCH]
Date: Wed, 30 Sep 2020 19:21:00 +0200	[thread overview]
Message-ID: <87k0wbji4j.fsf@gmx.de> (raw)
In-Reply-To: <83wo0biboa.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Sep 2020 17:25:41 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> commit 33512cbeb168764f83f5a740090ce40b4b948591
>> Author:     Luc Teirlinck <teirllm@auburn.edu>
>> AuthorDate: Wed Jun 1 20:51:03 2005 +0000
>>
>>     (auto-revert-buffers): Use save-match-data.
>
> It could be due to remote files (and file-handlers)?

Could be the case. There is no promise that the file name handlers do
not change match data. And I'm kind of sure this save-match-data form
has been introduced after such an accident, that auto-revert has
corrupted somebody's match data.

So please keep it. It doesn't hurt.

Best regards, Michael.





  parent reply	other threads:[~2020-09-30 17:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  6:26 bug#43714: 28.1: auto-revert code improvements [PATCH] Boruch Baum
2020-09-30 13:48 ` Lars Ingebrigtsen
2020-09-30 14:25   ` Eli Zaretskii
2020-09-30 15:28     ` Boruch Baum
2020-09-30 16:03       ` Eli Zaretskii
2020-09-30 16:59         ` Boruch Baum
2020-09-30 17:01           ` Lars Ingebrigtsen
2020-09-30 17:13             ` Boruch Baum
2020-09-30 17:21     ` Michael Albinus [this message]
2020-09-30 15:09   ` Boruch Baum
2020-09-30 15:12     ` Lars Ingebrigtsen
2020-09-30 17:41     ` Glenn Morris
2020-09-30 18:33       ` Boruch Baum
2020-09-30 23:55         ` Lars Ingebrigtsen
2020-10-01  5:42           ` Boruch Baum
2020-09-30 16:51 ` bug#43714: [boruch_baum@gmx.com: Re: bug#43714: 28.1: auto-revert code improvements [PATCH]] Boruch Baum
2020-09-30 16:54   ` Lars Ingebrigtsen
2020-09-30 17:10     ` Boruch Baum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0wbji4j.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=43714@debbugs.gnu.org \
    --cc=boruch_baum@gmx.com \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).