From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Date: Wed, 30 Sep 2020 12:59:34 -0400 Message-ID: <20200930165857.6sdswdttxiy4gly7@E15-2016.optimum.net> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> <83wo0biboa.fsf@gnu.org> <20200930152827.jseuon2q2xeh2om6@E15-2016.optimum.net> <83h7rfi74k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17403"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: larsi@gnus.org, 43714@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 19:08:30 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNfag-0004Pz-38 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 19:08:30 +0200 Original-Received: from localhost ([::1]:49830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNfae-00005b-Qq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 13:08:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNfSV-0001SF-7Y for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 13:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNfSU-00086s-QW for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 13:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNfSU-0001cA-P6 for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014851856158 (code B ref 43714); Wed, 30 Sep 2020 17:00:02 +0000 Original-Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 16:59:45 +0000 Original-Received: from localhost ([127.0.0.1]:32936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfSD-0001bF-JK for submit@debbugs.gnu.org; Wed, 30 Sep 2020 12:59:45 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:40745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNfSC-0001b1-Hk for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 12:59:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601485178; bh=s9o16xf0NHtbmbdfNzDbYwuh18DiQ/V0w1N+Jv8pEws=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=gPPXr/UdVVQjGkP8hK506qx9JAHu7mmo9mnxLTArvrUFJ5BcaN6oxuDJ3enbfB9sf f0xnGQ8UkuUpvMVbUyqFBHO8c8vNMnRIPiQh0x4h67k4wZcfJ0hOmwy1K+3l7O2woo T5eTDkoIlivL+Dt1GsTIeRzrTk3B6S0lPq/3Czvo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MxDou-1kcyLB3Olk-00xdSI; Wed, 30 Sep 2020 18:59:38 +0200 Content-Disposition: inline In-Reply-To: <83h7rfi74k.fsf@gnu.org> X-Provags-ID: V03:K1:JldTGgmEB1a7CKO5plAm+YHH6OvkT+QSwLwQRoCWzWnU6xMTIRA VUDNoK9rNtrtIB/gzMPzc8vrVUtcL0VE/6+AwbF0XsE2QdQbmCfcu2aB5YguCV3Q3NRniKJ Op8vUjooORs5L82Xu6GeHFiSa2z6+ysumVIc/wlGNDv+1aruAvSe6MBtBjFPnCYVc0rg+gp eTDbdt/dx59Dh5Z/H2h4A== X-UI-Out-Filterresults: notjunk:1;V03:K0:hXsSYRWMH88=:TV36Ws+8s2fAaIEtQTg/Or Wp9VNR/3EuJ4N1P3I/CkJBqJhoIWJlYseWAXiIox6yHfBBbogqu9jCDdd26jKOmKu6dLIPV5T 5fVeL1FVxnbuRuAezrW0GGdcr4NixVZwtg+s18mf6Amn+Rau3GUO+7sc1lyb+EvUqhTQQQFGR b+92rCx8twlyQFsgCohQozTvG9UOkzmmUdu5fnvtsZJsm04zCxVfcfor3nh7o2Wln6W3LIzyh ft2zd6oatnKm85JW254L+ebaT91zs+nnjCl6ZQCfL9Vy4klv95xOAnRaUaZjzprx20BS2NsBj BxRX28APgGpAQp9hD3Bpa9iB8EUmstC/Fl227KGLE+NQDl48VmIjYDbg77rhYlSlwevFe+S4I fTmLpgTHekX3Hk+DzHfZZoj66jJljLXug/aXlYumzY2h5R6pUMk3n7NMitVQ26wBei/UJHUpf H6p8G3YWm8F6svRz6xudJ8qiFp4+a+/k+A7i3AD3KCMFS9PByEiieN4a5GpWv8BKPwG6Swkoi /bxYRonaqwDO7+wEIK1MQwfGsWUnX10GQ1TSTNZ7F0wMaka+U4FC3MDKykY3UojhkqVWzx9D3 7XgUbycYaRHkCW+TGDgeWNv5oNUA7PKyTkNEnoWCV6G85ORxAnCWqjNoRO/gEIdmwkyLR2YcV a2gr8cV8QQaaRW/zRIjjgCf6Ad/9eQ1DCfGcuH1l/yeeKzm7q/Ru41WnIO4YKq0vkYGpfaLrh gGj/T9VGOUGKXJ7o1Hjg2aPRQmgtHIWnev/33OA+jeVzXi1wnwIeEqbTLFTd2NVMOreBLfAx X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189397 Archived-At: On 2020-09-30 19:03, Eli Zaretskii wrote: > Why is that a problem to leave save-match-data alone? Does it do any > harm? I explicitly said in the introduction to the patch that it wasn't 'fixing' anything broken, just cleaning things up (potentially / hopefully). When I was researching how to best implement that "auto-revert only if visible" feature, I found myself puzzling over some parts of the code and came to clean it up to be better able to wok on it. That said, You could leave the (save-match-data alone, and accept the othe= r changes; the other proposed changes are clearly independent. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0