From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.bugs Subject: bug#34513: Fwd: Re: bug#34513: display-line-numbers in term mode Date: Wed, 27 Feb 2019 18:46:56 +0100 Message-ID: <20190227174656.ysbxuhz332gvhkpq@Ergus> References: <20190217141940.62v754v46qwfcs2i@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="93617"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 To: 34513@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 27 18:48:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gz3Jj-000OGk-VZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 18:48:28 +0100 Original-Received: from localhost ([127.0.0.1]:48327 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz3Ji-0005VF-Q7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Feb 2019 12:48:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gz3JU-0005Tq-3z for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:48:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gz3JN-00077i-GH for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:48:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40762) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gz3JK-00075h-03 for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:48:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gz3JJ-0006DT-P4 for bug-gnu-emacs@gnu.org; Wed, 27 Feb 2019 12:48:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <20190217141940.62v754v46qwfcs2i@Ergus> Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Feb 2019 17:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34513 X-GNU-PR-Package: emacs Original-Received: via spool by 34513-submit@debbugs.gnu.org id=B34513.155128963123834 (code B ref 34513); Wed, 27 Feb 2019 17:48:01 +0000 Original-Received: (at 34513) by debbugs.gnu.org; 27 Feb 2019 17:47:11 +0000 Original-Received: from localhost ([127.0.0.1]:54306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz3IU-0006CL-Vc for submit@debbugs.gnu.org; Wed, 27 Feb 2019 12:47:11 -0500 Original-Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:36493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gz3IS-0006C7-EB for 34513@debbugs.gnu.org; Wed, 27 Feb 2019 12:47:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1551289622; bh=yfU2b3YUq9L6OpiYOPmAmgUz3TwYBhwD5HAj5kXROIU=; h=Date:From:To:Subject:From:Subject; b=EUemOXTsKdsCRksklwtosdKMZRpPtOnzMRsfSDLKg77CRvuCJINEMl55Mk630n4qYxQ3+hi7lg5aqzFzMbV/ISLebIqe5N43X0y7efg3TmiqUoGNXOuMaTy0hiHqBN/TZ6asaMe++95jiCfFlW3qfFf6M88jlBKCYKkreQSL1j8OjxLOjXVjsCdOjaNAk6FxfHA2pptN+6OUf0NW9DNDDKtimgRfHBMTxckpV+pF6jKn4KfqfatYP+MoZWiAdGfE2mP9ECQhe23DqWFcXLdI3Jnj8DQHk+WacEJQKBXUQYCLb3s2IxVNfQNI1amkx7FkkKJ+kayYjrM3Od6LNjFkZA== X-YMail-OSG: d5L03SUVM1nq8DG.hFiXAIco28GgBkO.DlUQVBmkqBs1EbYj6TZz..qCo1PuRZ4 CMHCw5lwbwKnVYbLllt6xAlsT4skQ6nfxRiodcOr2TDD_MS9ATIh8YPjXgCdVwslXXETV2FtG9jU gnl5pl_FZZ9dXPMGE4SQ.VsD9MC4wuvDLJoBQXXOV3cbAeypf.ibarVwO34fRn94DmVctjio.bhO uR2qgqSD37fcdtVRb72ePW2BH0j7kgepYd8FYgZKRc2xINE77iqz6B6dDI9WCNynO1h3S_iVTdwj VjIQOv4nB4EY3_zjNi9_DvynlAzppjFd6NpID6AzUzMzoRyjy3mihHSQtL9BOePi8JYkgQACnjRI Bm2bBohuz5COFxSoDiSY5vhjYcZd1_ne4LwzwF3E.rhfDuWFC4j54bpm1bqxzWCr2CzIrdTGJOZO Uut7SxCcqiaLp6ngF8ftAoWthkO0JoNx4Eg2QEEJRQm1HyuR480JlpOyEThCz7fE1lh5ZLgnm_mT 1kw4.TL3gbk8KtAJNpHaJpWAZxeJJ0Hze.xP55QYv3RH7LW3M3N0s0RHJMtk0sS2iQXnjZk0FpmP YInospCGuj3M9x7YxcfMQRnvQDwhfJbaGwR0phqT2WDZHwsMqYiQCNjXv8g3RkPTfjz0DxbeouKr wYfxY9twKdgwzDL9ead22h0y2BTUPNdEsk9ywOy80X1_3ipqNydOvcwiwxJrM0DkT6ekkyjWx29u 9qaD22.uVGW9KK9s8rMfU8_jzc0sKYhJ6fsAMDwKsbS5w7AR6INLgng6HxDdhnwAPuq6Vfu3dTp_ e5aa_WhWldrXW6.CxWarm1RJnEAl6VeaqbLqkv9MHs Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Wed, 27 Feb 2019 17:47:02 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp402.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID c7e69db5c44fa8a0d293855f7ec01184 for <34513@debbugs.gnu.org>; Wed, 27 Feb 2019 17:47:00 +0000 (UTC) Content-Disposition: inline X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155864 Archived-At: Yes I see the limitations, specially when the (line-number-display-width) changes due to user interaction. The problem is that for a real fix maybe it needs a hook like line-number-display-width-change (or equivalent) where to add actions, I suppose there are potentially other modes with same issue. But I think this is a bit overkill because it will require a redraw and the previous lines will be modified. The simplest to do (in my opinion) is to make the numbers not available at all in term mode and avoid display-line-numbers to be enabled in term mode. It will keep both the display-line-numbers and term.el implementations simpler. If a user really needs the numbers in the future then we can consider other solutions. But it makes not too much sense actually to have the line numbers in term mode. My report was because I faced the existent issue by default and it required an action in my config to avoid exposing it, not because I wanted the numbers. But again, you have much much more experience on this and a better opinion about what should be there or not.