From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#24767: jgraph comments not recognized any more Date: Sun, 23 Oct 2016 15:34:09 +0000 Message-ID: <20161023153409.GA23704@acm.fritz.box> References: <83bmybpp1s.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1477236929 18660 195.159.176.226 (23 Oct 2016 15:35:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Oct 2016 15:35:29 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Stefan Monnier , 24767@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 23 17:35:25 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byKnl-0002JD-HA for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2016 17:35:09 +0200 Original-Received: from localhost ([::1]:41443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byKnn-0002IY-Un for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Oct 2016 11:35:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byKnh-0002HG-MH for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 11:35:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byKne-0001zu-JM for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 11:35:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33717) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1byKne-0001zF-GK for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 11:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1byKne-0000mZ-7T for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2016 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2016 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24767 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24767-submit@debbugs.gnu.org id=B24767.14772368782970 (code B ref 24767); Sun, 23 Oct 2016 15:35:02 +0000 Original-Received: (at 24767) by debbugs.gnu.org; 23 Oct 2016 15:34:38 +0000 Original-Received: from localhost ([127.0.0.1]:49114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byKnG-0000lq-0W for submit@debbugs.gnu.org; Sun, 23 Oct 2016 11:34:38 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:43860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byKnE-0000lh-EU for 24767@debbugs.gnu.org; Sun, 23 Oct 2016 11:34:36 -0400 Original-Received: (qmail 66148 invoked by uid 3782); 23 Oct 2016 15:34:34 -0000 Original-Received: from acm.muc.de (p548C6AED.dip0.t-ipconnect.de [84.140.106.237]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 23 Oct 2016 17:34:32 +0200 Original-Received: (qmail 23710 invoked by uid 1000); 23 Oct 2016 15:34:09 -0000 Content-Disposition: inline In-Reply-To: <83bmybpp1s.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124901 Archived-At: Hello, Eli. On Sun, Oct 23, 2016 at 09:17:19AM +0300, Eli Zaretskii wrote: > > From: Stefan Monnier > > Date: Sat, 22 Oct 2016 17:24:01 -0400 > > > > % emacs -Q -l .../elpa/packages/jgraph-mode/jgraph-mode.el ~/foo.jgr > > (* hello *) > > > > The string "(* hello *)" should be highlighted as a comment, and is > > indeed correctly highlighted this way in Emacs-25 (and Emacs-24), but > > not in "master". > > > > The particularity of jgraph-mode's handling of (*...*) is that ?(, ?), > > and ?* are given "symbol" syntax, so I guess that src/syntax.c was > > modified in a way which makes it skip the whole (* as being a symbol. > I suspect 9dcf599. Alan, could you please take a look? Yes, 9dcf599 is indeed where the bug was introduced. I'll be looking at it. > Stefan, I think it would be good to have a test for this in the test > suite, even if for now it will fail. > Thanks. -- Alan Mackenzie (Nuremberg, Germany).