bug#2110: 23.0.60; vc-annotate-revision-previous-to-line fails on git

bug#2110: 23.0.60; vc-annotate-revision-previous-to-line fails on git

[Eric Hanchrow]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Place the following into a file, make it executable, and run it:

    #!/bin/bash

    d=$(mktemp -d)
    cd $d
    git init

    for i in $(seq 4)
    do echo $i > i
        git add i
        git commit -m $i
    done

    cat<<EOF > bug.el
    (find-file "i")
    (message "vc-handled-backends: %s" vc-handled-backends)
    (call-interactively 'vc-annotate)
    (call-interactively 'vc-annotate-revision-previous-to-line)
    EOF

    emacs --no-site-file --batch -l bug.el

The output I see is

    Initialized empty Git repository in /tmp/tmp.OYiYC29959/.git/
    [master (root-commit) df7f76c] 1
     1 files changed, 1 insertions(+), 0 deletions(-)
     create mode 100644 i
    [master 767a453] 2
     1 files changed, 1 insertions(+), 1 deletions(-)
    [master b0271d9] 3
     1 files changed, 1 insertions(+), 1 deletions(-)
    [master e46c84d] 4
     1 files changed, 1 insertions(+), 1 deletions(-)
    Warning: Lisp directory `/usr/local/share/emacs/23.0.60/site-lisp'
does not exist.
    Warning: Lisp directory `/usr/local/share/emacs/site-lisp' does not exist.
    Loading vc-git...
    vc-handled-backends: (RCS CVS SVN SCCS Bzr Git Hg Mtn Arch)
    Annotating...
    Redisplaying annotation...
    Redisplaying annotation...done (Spanned from 0.3 to 0.3 days old)
    Mark set
    Annotating... done
    Annotating...
    Running git blame undefined i...FAILED (status 128)

The bug is the failure in the last line.

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/src/emacs-with-my-tweaks.git/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.11 (i686-pc-linux-gnu, GTK+ Version 2.14.4)
 of 2009-01-29 on flap
Windowing system distributor `The X.Org Foundation', version 11.0.10502000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Shell-script

Minor modes in effect:
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-netsplit-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-autojoin-mode: t
  erc-track-mode: t
  erc-match-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-readonly-mode: t
  desktop-save-mode: t
  display-time-mode: t
  global-auto-revert-mode: t
  diff-auto-refine-mode: t
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
= m k t e m p <return> c d SPC $ d <return> g i t SPC
i n i t <return> C-x o C-x b s h e <return> C-r s e
q SPC C-c C-a C-SPC C-e M-w C-x o C-y C-a C-o C-n C-M-n
C-d <return> C-M-n C-a M-f M-f M-f M-f C-d <return>
M-f M-f M-f C-d <return> M-f M-f M-f M-f C-d <return>
C-x h C-M-\ M-> <return> <return> C-x o M-> C-x b b
u <return> C-x o c a t SPC > > <backspace> <backspace>
<backspace> < < C-x o C-x h M-w C-x 0 C-y C-x C-o M->
SPC > SPC b u g . e l <return> <return> C-x 2 C-x b
s h e <return> C-c C-p M-f M-f C-f C-SPC C-e M-w C-x
o C-y M-b M-b <M-backspace> <M-backspace> <backspace>
M-> <return> C-x C-s C-x o M-> c SPC d . . <backspace>
<backspace> <backspace> <backspace> d SPC . . <return>
r m SPC - r f SPC x <return> c h m o d SPC + x SPC
b u <tab> s <tab> <return> . / b u <tab> s <tab> <return>
C-x o C-p C-p C-p M-f C-k C-p C-p C-p C-p C-p C-e C-y
C-x C-s C-x o M-p <return> C-x o M-< C-x o l t | h
e a d <return> C-x o C-n C-n C-f C-f $ ( C-e ) C-x
C-s C-x o M-r b u g <return> <return> C-x d <return>
g s M-< n n n n n n C-x o C-b SPC - d C-x C-s C-x o
q M-p <return> C-x d <return> g C-u C-p C-p a q C-x
0 M-x r e p o e r <backspace> <backspace> r t - e m
<tab> <return>

Recent messages:
Completed
Mark set
Wrote /tmp/bug.sh
History item: 1
Mark set
Wrote /tmp/bug.sh
History item: 2
Mark set
Wrote /tmp/bug.sh
History item: 1

bug#2110: 23.0.60; vc-annotate-revision-previous-to-line fails on git

[Dan Nicolaescu]

Eric Hanchrow <eric.hanchrow@gmail.com> writes:

  > Please write in English if possible, because the Emacs maintainers
  > usually do not have translators to read other languages for them.
  > 
  > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
  > 
  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug:
  > 
  > Place the following into a file, make it executable, and run it:
  > 
  >     #!/bin/bash
  > 
  >     d=$(mktemp -d)
  >     cd $d
  >     git init
  > 
  >     for i in $(seq 4)
  >     do echo $i > i
  >         git add i
  >         git commit -m $i
  >     done
  > 
  >     cat<<EOF > bug.el
  >     (find-file "i")
  >     (message "vc-handled-backends: %s" vc-handled-backends)
  >     (call-interactively 'vc-annotate)
  >     (call-interactively 'vc-annotate-revision-previous-to-line)
  >     EOF
  > 
  >     emacs --no-site-file --batch -l bug.el
  > 
  > The output I see is
  > 
  >     Initialized empty Git repository in /tmp/tmp.OYiYC29959/.git/
  >     [master (root-commit) df7f76c] 1
  >      1 files changed, 1 insertions(+), 0 deletions(-)
  >      create mode 100644 i
  >     [master 767a453] 2
  >      1 files changed, 1 insertions(+), 1 deletions(-)
  >     [master b0271d9] 3
  >      1 files changed, 1 insertions(+), 1 deletions(-)
  >     [master e46c84d] 4
  >      1 files changed, 1 insertions(+), 1 deletions(-)
  >     Warning: Lisp directory `/usr/local/share/emacs/23.0.60/site-lisp'
  > does not exist.
  >     Warning: Lisp directory `/usr/local/share/emacs/site-lisp' does not exist.
  >     Loading vc-git...
  >     vc-handled-backends: (RCS CVS SVN SCCS Bzr Git Hg Mtn Arch)
  >     Annotating...
  >     Redisplaying annotation...
  >     Redisplaying annotation...done (Spanned from 0.3 to 0.3 days old)
  >     Mark set
  >     Annotating... done
  >     Annotating...
  >     Running git blame undefined i...FAILED (status 128)
  > 
  > The bug is the failure in the last line.

This is because vc-git-previous-revision calls vc-git-symbolic-commit
which runs:
git name-rev --name-only --tags COMMIT
which returns "undefined"
running just:
git name-rev --name-only COMMIT
seems to be better in this particular case.  No idea if that's TRTD
though...