From: Dan Nicolaescu <dann@ics.uci.edu>
To: Eric Hanchrow <eric.hanchrow@gmail.com>
Cc: 2110@emacsbugs.donarmstrong.com
Subject: bug#2110: 23.0.60; vc-annotate-revision-previous-to-line fails on git
Date: Fri, 30 Jan 2009 22:39:00 -0800 (PST) [thread overview]
Message-ID: <200901310639.n0V6d0hS000858@rodan.ics.uci.edu> (raw)
In-Reply-To: <36366a980901292001x6e4ac843x6406ce5f0e8a261c@mail.gmail.com> (Eric Hanchrow's message of "Thu, 29 Jan 2009 20:01:06 -0800")
Eric Hanchrow <eric.hanchrow@gmail.com> writes:
> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.
>
> Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
>
> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:
>
> Place the following into a file, make it executable, and run it:
>
> #!/bin/bash
>
> d=$(mktemp -d)
> cd $d
> git init
>
> for i in $(seq 4)
> do echo $i > i
> git add i
> git commit -m $i
> done
>
> cat<<EOF > bug.el
> (find-file "i")
> (message "vc-handled-backends: %s" vc-handled-backends)
> (call-interactively 'vc-annotate)
> (call-interactively 'vc-annotate-revision-previous-to-line)
> EOF
>
> emacs --no-site-file --batch -l bug.el
>
> The output I see is
>
> Initialized empty Git repository in /tmp/tmp.OYiYC29959/.git/
> [master (root-commit) df7f76c] 1
> 1 files changed, 1 insertions(+), 0 deletions(-)
> create mode 100644 i
> [master 767a453] 2
> 1 files changed, 1 insertions(+), 1 deletions(-)
> [master b0271d9] 3
> 1 files changed, 1 insertions(+), 1 deletions(-)
> [master e46c84d] 4
> 1 files changed, 1 insertions(+), 1 deletions(-)
> Warning: Lisp directory `/usr/local/share/emacs/23.0.60/site-lisp'
> does not exist.
> Warning: Lisp directory `/usr/local/share/emacs/site-lisp' does not exist.
> Loading vc-git...
> vc-handled-backends: (RCS CVS SVN SCCS Bzr Git Hg Mtn Arch)
> Annotating...
> Redisplaying annotation...
> Redisplaying annotation...done (Spanned from 0.3 to 0.3 days old)
> Mark set
> Annotating... done
> Annotating...
> Running git blame undefined i...FAILED (status 128)
>
> The bug is the failure in the last line.
This is because vc-git-previous-revision calls vc-git-symbolic-commit
which runs:
git name-rev --name-only --tags COMMIT
which returns "undefined"
running just:
git name-rev --name-only COMMIT
seems to be better in this particular case. No idea if that's TRTD
though...
prev parent reply other threads:[~2009-01-31 6:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 4:01 bug#2110: 23.0.60; vc-annotate-revision-previous-to-line fails on git Eric Hanchrow
2009-01-31 6:39 ` Dan Nicolaescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901310639.n0V6d0hS000858@rodan.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=2110@emacsbugs.donarmstrong.com \
--cc=eric.hanchrow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).