unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Gabriel Beauchamp <beauchampgabriel@gmail.com>
Cc: 32755@debbugs.gnu.org
Subject: bug#32755: [PATCH] erc.el: Remove warning during compilation.
Date: Mon, 17 Sep 2018 23:19:28 -0400	[thread overview]
Message-ID: <1kfty7sda7.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87d0tbiz5b.fsf@gmail.com> (Gabriel Beauchamp's message of "Mon,  17 Sep 2018 17:37:20 -0400")

Gabriel Beauchamp wrote:

> I have attached a patch that removes a warning during the compilation of
> erc. Tested with `emacs -Q -q' running on HEAD.

Thanks for the patch, however if someone writes FIXME for this kind of
thing rather than just doing it, it's usually because it's not so
straightforward. In this case, `str' is an advertised part of the
interface - see doc of `erc-send-pre-hook'.

> Subject: [PATCH] * lisp/erc/erc.el (erc-handle-irc-url): Remove
> warning during compilation.

You changed erc-send-input, not erc-handle-irc-url.
(You can use eg C-x 4 a on the diff for this kind of thing.)





      reply	other threads:[~2018-09-18  3:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 21:37 bug#32755: [PATCH] erc.el: Remove warning during compilation Gabriel Beauchamp
2018-09-18  3:19 ` Glenn Morris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1kfty7sda7.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=32755@debbugs.gnu.org \
    --cc=beauchampgabriel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).