unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Gabriel Beauchamp <beauchampgabriel@gmail.com>
To: 32755@debbugs.gnu.org
Subject: bug#32755: [PATCH] erc.el: Remove warning during compilation.
Date: Mon, 17 Sep 2018 17:37:20 -0400	[thread overview]
Message-ID: <87d0tbiz5b.fsf@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

Hi,

I have attached a patch that removes a warning during the compilation of
erc. Tested with `emacs -Q -q' running on HEAD.

Thanks,
Gabriel


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Remove warning during compilation --]
[-- Type: text/x-diff, Size: 1603 bytes --]

From cc6d9c0c83fb62172aec5456c1ae16f217478346 Mon Sep 17 00:00:00 2001
From: Gabriel Beauchamp <beauchampgabriel@gmail.com>
Date: Mon, 17 Sep 2018 17:07:13 -0400
Subject: [PATCH] * lisp/erc/erc.el (erc-handle-irc-url): Remove warning during
 compilation.

---
 lisp/erc/erc.el | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index fc51009641..eb9082fa2f 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -5450,14 +5450,14 @@ erc-send-input
       (beep))
     nil)
    (t
-    (defvar str) ;; FIXME: Make it obey the "erc-" prefix convention.
-    (let ((str input)
+    (defvar erc--str)
+    (let ((erc--str input)
           (erc-insert-this t))
       (setq erc-send-this t)
       (run-hook-with-args 'erc-send-pre-hook input)
       (when erc-send-this
-        (if (or (string-match "\n" str)
-                (not (string-match erc-command-regexp str)))
+        (if (or (string-match "\n" erc--str)
+                (not (string-match erc-command-regexp erc--str)))
             (mapc
              (lambda (line)
                (mapc
@@ -5468,8 +5468,8 @@ erc-send-input
                                           (null erc-flood-protect) t))
                 (or (and erc-flood-protect (erc-split-line line))
                     (list line))))
-             (split-string str "\n"))
-          (erc-process-input-line (concat str "\n") t nil))
+             (split-string erc--str "\n"))
+          (erc-process-input-line (concat erc--str "\n") t nil))
         t)))))
 
 (defun erc-display-command (line)
-- 
2.17.1


             reply	other threads:[~2018-09-17 21:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 21:37 Gabriel Beauchamp [this message]
2018-09-18  3:19 ` bug#32755: [PATCH] erc.el: Remove warning during compilation Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0tbiz5b.fsf@gmail.com \
    --to=beauchampgabriel@gmail.com \
    --cc=32755@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).