From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#32755: [PATCH] erc.el: Remove warning during compilation. Date: Mon, 17 Sep 2018 23:19:28 -0400 Message-ID: <1kfty7sda7.fsf@fencepost.gnu.org> References: <87d0tbiz5b.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1537240686 32069 195.159.176.226 (18 Sep 2018 03:18:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2018 03:18:06 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 32755@debbugs.gnu.org To: Gabriel Beauchamp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 18 05:18:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g26WX-0008Bz-9d for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Sep 2018 05:18:01 +0200 Original-Received: from localhost ([::1]:38240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g26Yd-0005ye-Nt for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Sep 2018 23:20:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g26YV-0005wR-6a for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 23:20:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g26YU-0002mV-Iu for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 23:20:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g26YU-0002lt-Eb for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 23:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g26YU-0006Ul-6Q for bug-gnu-emacs@gnu.org; Mon, 17 Sep 2018 23:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Sep 2018 03:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32755-submit@debbugs.gnu.org id=B32755.153724077724933 (code B ref 32755); Tue, 18 Sep 2018 03:20:02 +0000 Original-Received: (at 32755) by debbugs.gnu.org; 18 Sep 2018 03:19:37 +0000 Original-Received: from localhost ([127.0.0.1]:43506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g26Y5-0006U5-6j for submit@debbugs.gnu.org; Mon, 17 Sep 2018 23:19:37 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:32825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g26Y3-0006Ts-OE for 32755@debbugs.gnu.org; Mon, 17 Sep 2018 23:19:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g26Xx-0000RZ-R9 for 32755@debbugs.gnu.org; Mon, 17 Sep 2018 23:19:30 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g26Xw-0000Pi-Gw; Mon, 17 Sep 2018 23:19:28 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1g26Xw-0001k6-CV; Mon, 17 Sep 2018 23:19:28 -0400 X-Spook: Airplane munitions National security Conficker ASIO DES X-Ran: ])c:ts!ySP8r0_kSQs=]smg~n>[_(THQi-o=H6~kU50%d93fPG[DSDSmXi-669pnr=~Uj6 X-Hue: brightwhite X-Attribution: GM In-Reply-To: <87d0tbiz5b.fsf@gmail.com> (Gabriel Beauchamp's message of "Mon, 17 Sep 2018 17:37:20 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150386 Archived-At: Gabriel Beauchamp wrote: > I have attached a patch that removes a warning during the compilation of > erc. Tested with `emacs -Q -q' running on HEAD. Thanks for the patch, however if someone writes FIXME for this kind of thing rather than just doing it, it's usually because it's not so straightforward. In this case, `str' is an advertised part of the interface - see doc of `erc-send-pre-hook'. > Subject: [PATCH] * lisp/erc/erc.el (erc-handle-irc-url): Remove > warning during compilation. You changed erc-send-input, not erc-handle-irc-url. (You can use eg C-x 4 a on the diff for this kind of thing.)