bug#52264: 28.0.90; M-x describe-input-method for chinese-cns-quick is missing K key

bug#52264: 28.0.90; M-x describe-input-method for chinese-cns-quick is missing K key

[Van Ly]

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]


The input method description is missing the K key in following input 
methods.

   M-x set-input-method
* chinese-cns-quick
* chinese-cns-tsangchi
* chinese-b5-quick
* chinese-b5-tsangchi

The K key is expected in the key sequence H J K L for QWERTY keyboard 
as shown in the *Help* buffer after invoking

   M-x describe-input-method

This is what it looks like, the K key is missing:
     [A 日] [S 尸] [D 木] [F 火] [G 土] [H 竹] [J 十] [L 中]

This is what a K key looks like inserted in the above key row:
     [A 日] [S 尸] [D 木] [F 火] [G 土] [H 竹] [J 十] [K 大] [L 中]

-- 
vl

bug#52264: 28.0.90; M-x describe-input-method for chinese-cns-quick is missing K key

[Eli Zaretskii]

> Date: Fri, 3 Dec 2021 18:26:33 +0000 (UTC)
> From: Van Ly <van.ly@sdf.org>
> 
> The input method description is missing the K key in following input 
> methods.
> 
>    M-x set-input-method
> * chinese-cns-quick
> * chinese-cns-tsangchi
> * chinese-b5-quick
> * chinese-b5-tsangchi

These input methods are auto-generated from files in MISC-DIC.  So I
wonder what should be added there, and why the K key is missing form
there?  maybe we should talk to the author, who seems to be Christian
Wittern <wittern@iis.sinica.edu.tw> (CC'ed)?

Thanks.

bug#52264: 28.0.90; M-x describe-input-method for chinese-cns-quick is missing K key

[Eli Zaretskii]

> Date: Fri, 03 Dec 2021 22:16:28 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 52264@debbugs.gnu.org
> 
> > Date: Fri, 3 Dec 2021 18:26:33 +0000 (UTC)
> > From: Van Ly <van.ly@sdf.org>
> > 
> > The input method description is missing the K key in following input 
> > methods.
> > 
> >    M-x set-input-method
> > * chinese-cns-quick
> > * chinese-cns-tsangchi
> > * chinese-b5-quick
> > * chinese-b5-tsangchi
> 
> These input methods are auto-generated from files in MISC-DIC.  So I
> wonder what should be added there, and why the K key is missing form
> there?  maybe we should talk to the author, who seems to be Christian
> Wittern <wittern@iis.sinica.edu.tw> (CC'ed)?

That address bounced; trying the latest one we have in Git.

bug#52264: [PATCH] M-x describe-input-method for chinese-cns-quick is missing K key

[Cameron Desautels]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

I can confirm that what Van is saying is correct.

The input methods do /work/ correctly, so just the docs are wrong.  And
that particular chart is hardcoded (i.e. not generated).  I did a bit of
git spelunking and it seems to have been wrong from the start; probably
just an accidental omission.

Without diving into a full explanation of how these input methods work,
if you select any one of these input methods and type any of the QWERTY
keys in the chart (and press SPACE to finalize the selection), you'll
see the corresponding Chinese character appear in the buffer.  K does,
in fact, produce 大, as a person familiar with Cangjie would expect.
Wikipedia has a decent page[1] if you want to learn more.

I hope that's helpful.  Patch attached.

[1]: https://en.wikipedia.org/wiki/Cangjie_input_method

-- 
Cameron Desautels <camdez@gmail.com>

[-- Attachment #2: 0001-Add-missing-K-key-documentation-for-Cangjie-input-me.patch --]
[-- Type: application/octet-stream, Size: 991 bytes --]

From 3ed413a174a6274ee3eed0bf2d463c8c77d42215 Mon Sep 17 00:00:00 2001
From: Cameron Desautels <camdez@gmail.com>
Date: Thu, 9 Dec 2021 00:08:14 -0800
Subject: [PATCH] Add missing K key documentation for Cangjie input methods

* lisp/international/titdic-cnv.el (tsang-quick-converter): Add
  missing K key in input method documentation. (Bug#52264)
---
 lisp/international/titdic-cnv.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/international/titdic-cnv.el b/lisp/international/titdic-cnv.el
index ccb4c8390b..daf287c07f 100644
--- a/lisp/international/titdic-cnv.el
+++ b/lisp/international/titdic-cnv.el
@@ -748,7 +748,7 @@ tsang-quick-converter
 
    [Q 手] [W 田] [E 水] [R 口] [T 廿] [Y 卜] [U 山] [I 戈] [O 人] [P 心]
 
-    [A 日] [S 尸] [D 木] [F 火] [G 土] [H 竹] [J 十] [L 中]
+    [A 日] [S 尸] [D 木] [F 火] [G 土] [H 竹] [J 十] [K 大] [L 中]
 
       [Z  ] [X 難] [C 金] [V 女] [B 月] [N 弓] [M 一]
 
-- 
2.34.1

bug#52264: [PATCH] M-x describe-input-method for chinese-cns-quick is missing K key

[Eli Zaretskii]

> From: Cameron Desautels <camdez@gmail.com>
> Date: Thu, 9 Dec 2021 00:29:55 -0800
> 
> I can confirm that what Van is saying is correct.
> 
> The input methods do /work/ correctly, so just the docs are wrong.  And
> that particular chart is hardcoded (i.e. not generated).  I did a bit of
> git spelunking and it seems to have been wrong from the start; probably
> just an accidental omission.
> 
> Without diving into a full explanation of how these input methods work,
> if you select any one of these input methods and type any of the QWERTY
> keys in the chart (and press SPACE to finalize the selection), you'll
> see the corresponding Chinese character appear in the buffer.  K does,
> in fact, produce 大, as a person familiar with Cangjie would expect.
> Wikipedia has a decent page[1] if you want to learn more.
> 
> I hope that's helpful.  Patch attached.

Thanks, I installed this on the emacs-28 branch, and I'm closing the
bug.