unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Cameron Desautels <camdez@gmail.com>
To: 52264@debbugs.gnu.org
Subject: bug#52264: [PATCH] M-x describe-input-method for chinese-cns-quick is missing K key
Date: Thu, 9 Dec 2021 00:29:55 -0800	[thread overview]
Message-ID: <CALtQdckDZv4siF9EqSLo5mE7Ao68iP+LEtpjgxCJ2=ciOc=bdg@mail.gmail.com> (raw)
In-Reply-To: <1bb8e7ba-26cf-8b4f-8eab-125f1985f81e@SDF.ORG>

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

I can confirm that what Van is saying is correct.

The input methods do /work/ correctly, so just the docs are wrong.  And
that particular chart is hardcoded (i.e. not generated).  I did a bit of
git spelunking and it seems to have been wrong from the start; probably
just an accidental omission.

Without diving into a full explanation of how these input methods work,
if you select any one of these input methods and type any of the QWERTY
keys in the chart (and press SPACE to finalize the selection), you'll
see the corresponding Chinese character appear in the buffer.  K does,
in fact, produce 大, as a person familiar with Cangjie would expect.
Wikipedia has a decent page[1] if you want to learn more.

I hope that's helpful.  Patch attached.

[1]: https://en.wikipedia.org/wiki/Cangjie_input_method

-- 
Cameron Desautels <camdez@gmail.com>

[-- Attachment #2: 0001-Add-missing-K-key-documentation-for-Cangjie-input-me.patch --]
[-- Type: application/octet-stream, Size: 991 bytes --]

From 3ed413a174a6274ee3eed0bf2d463c8c77d42215 Mon Sep 17 00:00:00 2001
From: Cameron Desautels <camdez@gmail.com>
Date: Thu, 9 Dec 2021 00:08:14 -0800
Subject: [PATCH] Add missing K key documentation for Cangjie input methods

* lisp/international/titdic-cnv.el (tsang-quick-converter): Add
  missing K key in input method documentation. (Bug#52264)
---
 lisp/international/titdic-cnv.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/international/titdic-cnv.el b/lisp/international/titdic-cnv.el
index ccb4c8390b..daf287c07f 100644
--- a/lisp/international/titdic-cnv.el
+++ b/lisp/international/titdic-cnv.el
@@ -748,7 +748,7 @@ tsang-quick-converter
 
    [Q 手] [W 田] [E 水] [R 口] [T 廿] [Y 卜] [U 山] [I 戈] [O 人] [P 心]
 
-    [A 日] [S 尸] [D 木] [F 火] [G 土] [H 竹] [J 十] [L 中]
+    [A 日] [S 尸] [D 木] [F 火] [G 土] [H 竹] [J 十] [K 大] [L 中]
 
       [Z  ] [X 難] [C 金] [V 女] [B 月] [N 弓] [M 一]
 
-- 
2.34.1


  parent reply	other threads:[~2021-12-09  8:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 18:26 bug#52264: 28.0.90; M-x describe-input-method for chinese-cns-quick is missing K key Van Ly
2021-12-03 20:16 ` Eli Zaretskii
2021-12-03 20:19   ` Eli Zaretskii
2021-12-09  8:29 ` Cameron Desautels [this message]
2021-12-09 11:04   ` bug#52264: [PATCH] " Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALtQdckDZv4siF9EqSLo5mE7Ao68iP+LEtpjgxCJ2=ciOc=bdg@mail.gmail.com' \
    --to=camdez@gmail.com \
    --cc=52264@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).