unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: btuin@mailo.com, 66152@debbugs.gnu.org,
	Stefan Kangas <stefankangas@gmail.com>
Subject: bug#66152: 30.0.50; Missing indent rules in c-ts-mode
Date: Fri, 12 Jan 2024 23:07:30 -0800	[thread overview]
Message-ID: <1E6C674F-E848-46A9-BD58-9396E872940B@gmail.com> (raw)
In-Reply-To: <83edeomlp0.fsf@gnu.org>



> On Jan 10, 2024, at 10:24 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Stefan Kangas <stefankangas@gmail.com>
>> Date: Wed, 10 Jan 2024 13:31:37 -0800
>> Cc: Eli Zaretskii <eliz@gnu.org>, btuin@mailo.com, 66152@debbugs.gnu.org
>> 
>> Yuan Fu <casouri@gmail.com> writes:
>> 
>>> LGTM, I applied the first patch to emacs-29.
>> 
>> What about patch 2 and 3?  Should they be installed on master?
> 
> Not sure.  It sounded like they were experimental, and no consensus
> was reached.

I had a look again, the first patch is applied, the second patch is fixed in another report, the third patch is still in discussion. Augustin said he’ll clean it up and extend it to apply to other modes if it’s desirable. I think it’s good to have, we just need to make sure it doesn’t bring any regression. Also I don’t know how widely used is this kind of comments and how important it is.

Yuan




  reply	other threads:[~2024-01-13  7:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 11:23 bug#66152: 30.0.50; Missing indent rules in c-ts-mode Augustin Chéneau
2023-09-26 12:29 ` Augustin Chéneau
2023-09-29  7:17   ` Eli Zaretskii
2023-10-05  7:16     ` Eli Zaretskii
2023-12-11  2:16       ` Yuan Fu
2024-01-10 21:31         ` Stefan Kangas
2024-01-11  6:24           ` Eli Zaretskii
2024-01-13  7:07             ` Yuan Fu [this message]
2024-01-14  5:33               ` Stefan Kangas
2024-01-14  7:09                 ` Eli Zaretskii
2024-01-14 10:21                 ` Augustin Chéneau via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11  2:41   ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1E6C674F-E848-46A9-BD58-9396E872940B@gmail.com \
    --to=casouri@gmail.com \
    --cc=66152@debbugs.gnu.org \
    --cc=btuin@mailo.com \
    --cc=eliz@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).