From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#16514: 24.3.50; Region overlay looks bad on refined hunks in diff-mode Date: Sun, 6 Dec 2020 21:34:44 +0200 Message-ID: <157e9a89-6d6c-1d3e-9308-e81d7442889a@yandex.ru> References: <87y52arljh.fsf@yandex.ru> <87lfebassa.fsf@gnus.org> <87k0tvt04n.fsf@gmail.com> <83r1o39bab.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: larsi@gnus.org, 16514@debbugs.gnu.org To: Eli Zaretskii , =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 06 20:35:38 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klzon-0004Jh-CD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 20:35:37 +0100 Original-Received: from localhost ([::1]:34442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klzom-0006of-9z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 14:35:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klzoE-0006ni-Fk for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klzoE-00069C-8G for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klzoE-0002iy-4j for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2020 19:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16514 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 16514-submit@debbugs.gnu.org id=B16514.160728329410456 (code B ref 16514); Sun, 06 Dec 2020 19:35:02 +0000 Original-Received: (at 16514) by debbugs.gnu.org; 6 Dec 2020 19:34:54 +0000 Original-Received: from localhost ([127.0.0.1]:51382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klzo6-0002iZ-6I for submit@debbugs.gnu.org; Sun, 06 Dec 2020 14:34:54 -0500 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:40910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klzo4-0002iL-AO for 16514@debbugs.gnu.org; Sun, 06 Dec 2020 14:34:52 -0500 Original-Received: by mail-ed1-f49.google.com with SMTP id h16so111931edt.7 for <16514@debbugs.gnu.org>; Sun, 06 Dec 2020 11:34:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9Q70BjEOcE7eWP8G2N4BdOcEXAz50Ily2puD/gDJjSw=; b=TPI+f/4Nn9TGnAWtNj673NmY9vlrUkBMO6SpHBhdx3FfppsgxXB98CyJQo551y4sej BNt9QVm4JOm4AwJbQ53u1oiRMV9udmt2/de+2dPHzMYekgcPw0v1tcNA8U676F9yULuG FhLZPgzvvXKRpsEvHksEFbTuSfK6BRMkVkNk3fBP1WUN10vZeH1ifKOXdmtJUE2WoYEB 8jVizdD047cSiXZgSoiQH02gF9znKMVUn2x443rRKkmfUfEN6tanaV9lqIJXcxVl+1Zd dExQq9xfBHfvDP5Y9do+W3fKvltYp7Uofr+Y8elUlZ7CIl2RfHU2wkTMdSph488gcdIy 4/Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9Q70BjEOcE7eWP8G2N4BdOcEXAz50Ily2puD/gDJjSw=; b=KxFSH6gqsYDO0F3kPbIbCFkrcdoz/vVbOcit+W56uWyJbWA/wV5qqBI3tmr1F5xqsI Ojmo5Ag8jsBMdaG0WYpDMBaOGJKf6n6djvGklk1TXi1QNk+jg77rIfKGPgW5cZVjY4qf 1pv2nw7mtninu2hIGJQb2jlSPd5mB1vwDiSVym8JLHefmUD0mPy/lGY3r7Dyn6hTY8rt qYwKkJYxNPl4INnWxdf67Cbw5p1zF+0UrrVTD5wcMtfQPw7tTwtWX9YPfxX9C38D7Sbm aeiEWwgJyUP3tx/0mrlYCrJVbgyOiWgRneKbsGT1WH5YD7VipFyVNNc55PErjjBwgrfz H/xg== X-Gm-Message-State: AOAM531aM1evsHCSIjhWKJRdZoDZiiskEhZkZEpDcTMFqke66cvwMZIf 3kpBffRjDHmhkqIeF9C0R2ZQy0KO+dssvg== X-Google-Smtp-Source: ABdhPJyWU/6zvLyCiS9eOd2zx6dStDSPY36Z7Un2PfPtImcW2e1eUJpzdDi86T+ds4NMUhfuM2Ctjg== X-Received: by 2002:aa7:d593:: with SMTP id r19mr17404172edq.246.1607283286451; Sun, 06 Dec 2020 11:34:46 -0800 (PST) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id bq20sm8660285ejb.64.2020.12.06.11.34.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 11:34:45 -0800 (PST) In-Reply-To: <83r1o39bab.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195165 Archived-At: On 06.12.2020 17:58, Eli Zaretskii wrote: >> From: Kévin Le Gouguec >> Date: Sun, 06 Dec 2020 16:39:04 +0100 >> Cc:16514@debbugs.gnu.org, Dmitry Gutov >> >> As long as point does not go past the refinement (before the comma), the >> region's background has the region face's background. >> >> Once point moves past the refinement, only non-refined parts keep the >> region face's background; refined parts keep the refinement background. > This is expected, since we sort overlays so that the one whose extent > is larger wins. > > To do anything else the overlays should have priorities. So it's probably correct from the low-level primitives POV. But is this a good UI? And shouldn't we maybe tweak the high-level implementation (perhaps, the way how the refinements are applied) so that the behavior is better?