bug#51523: 29.0.50; gnus-mime-view-part-externally very slow

[Gregory Heytings <gregory@heytings.org>]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]


>
> You don't need to expand the file name you pass to file-attributes: it 
> does that internally.  What you need is to expand the file name you pass 
> as the key, i.e. for the symbol you are generating from the file name.
>

Whoops, sorry, that's what I meant to do of course, I went too fast. 
Sorry again for the confusion.

[-- Attachment #2: Type: text/x-diff, Size: 1813 bytes --]

From 56037a349fdefb5929347fb19a5682b627fc476b Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Wed, 3 Nov 2021 13:24:51 +0000
Subject: [PATCH] Further improvement of file-has-changed-p

* lisp/files.el (file-has-changed-p): Expand the file name when necessary.
Clarify and fix typo in the docstring.
---
 lisp/files.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lisp/files.el b/lisp/files.el
index 173198a424..2cd932adfd 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -6187,16 +6187,19 @@ file-has-changed-p--hash-table
 (defun file-has-changed-p (file &optional tag)
   "Return non-nil if FILE has changed.
 The size and modification time of FILE are compared to the size
-and modification time of tghe same FILE during a previous
+and modification time of the same FILE during a previous
 invocation of `file-has-changed-p'.  Thus, the first invocation
-of `file-has-changed-p' always returns non-nil.
+of `file-has-changed-p' on a given FILE always returns non-nil.
 The optional argument TAG, which must be a symbol, can be used to
 limit the comparison to invocations with identical tags; it can be
 the symbol of the calling function, for example."
   (let* ((fileattr (file-attributes file 'integer))
 	 (attr (cons (file-attribute-size fileattr)
 		     (file-attribute-modification-time fileattr)))
-	 (sym (concat (symbol-name tag) "@" file))
+	 (sym (concat (symbol-name tag) "@"
+                      (if (file-name-absolute-p file)
+                          file
+                        (expand-file-name file))))
 	 (cachedattr (gethash sym file-has-changed-p--hash-table)))
      (when (not (equal attr cachedattr))
        (puthash sym attr file-has-changed-p--hash-table))))
-- 
2.33.0